Opened 6 years ago

Last modified 5 years ago

#10247 assigned Bug

[Webkit] Enter key before sub list is not right

Reported by: Piotrek Koszuliński Owned by: Olek Nowodziński
Priority: Normal Milestone:
Component: General Version: 4.0
Keywords: Webkit IBM Cc: satya_minnekanti@…

Description

<ol>
	<li>item1</li>
	<li>&nbsp;
	<ol>
		<li>item2</li>
	</ol>
	</li>
</ol>

Place caret at the beginning of second list item (nbsp) and press enter.

Result:

<ol>
	<li>^item1</li>
	<li>&nbsp;</li>
	<li>&nbsp;
	<ol>
		<li>item2</li>
	</ol>
	</li>
</ol>

Note that the caret was moved up to the item 1.

I was able to reproduce this on Chrome, but not on FF.

Change History (9)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Expected result:

<ol>
	<li>item1</li>
	<li>&nbsp;</li>
	<li>^&nbsp;
	<ol>
		<li>item2</li>
	</ol>
	</li>
</ol>

comment:2 Changed 6 years ago by Jakub Ś

Status: newconfirmed
Version: 4.0

Problem can be reproduced on both Chrome and Safari in Win and Mac from CKEditor 4.0 (4.0 beta works fine).

comment:3 Changed 5 years ago by Piotrek Koszuliński

Keywords: IBM added

DUP reported: #10810.

comment:4 Changed 5 years ago by Piotrek Koszuliński

Another DUP: #6448.

comment:5 Changed 5 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added

cc

comment:6 Changed 5 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmedassigned

comment:7 Changed 5 years ago by Olek Nowodziński

git:17798bb0e282a is the first bad commit.

comment:8 Changed 5 years ago by Piotrek Koszuliński

I suppose it may be a filling char which should be removed before the action or skipped by some algorithm. Good luck :)

comment:9 Changed 5 years ago by Olek Nowodziński

Pushed two tests to dt/plugins/enter/list.html (t/10247).

Recent discoveries:

It feels like the correct way to fix the issue provided a right condition to bypass that removal is found.

I'm not sure whether removing it totally would be a good idea because we may experience unknown regressions (despite of passing tests). On the other hand, since that line belongs to #1272, which I'm unable to re-produce, it may be that this block is nothing but a little troublemaker and a dead piece of code. We need to check this out.

  • Removing this condition (introduced by the first bad commit) also makes dt/plugins/enter/list.html green but some of dt/core/selection/editor.html fail. IMO it's nothing like a good solution.
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy