Opened 6 years ago

Closed 6 years ago

#10315 closed Bug (fixed)

[Webkit] Undo manager records snapshots after filling char has been removed/added

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.1.1
Component: General Version:
Keywords: Cc:

Description

This affects undoM.save() but also lock()/unlock().

Change History (6)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newassigned

comment:2 Changed 6 years ago by Piotrek Koszuliński

Status: assignedreview

Pushed t/10315 on dev and tests.

Branches are based on #10131 which should be reviewed first.

comment:3 Changed 6 years ago by Piotrek Koszuliński

Pushed t/10315b on dev and updated tests to t/10315b.

During working on #10291 I found that there already exists code that should hide filling char when creating snapshot image. So I reused existing functionality of image in lock/unlock.

However, that wasn't the only issue. It turned out that code that should invalidate filling char caches editable instance and stops working after editable is replaced by new one. I fixed that too.

comment:4 Changed 6 years ago by Piotrek Koszuliński

t/10315b fixes also #10321.

comment:5 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:6 Changed 6 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Fixed on master with git:24a7ca4 on dev and 65cc722 on tests.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy