Opened 12 years ago
Closed 12 years ago
#10315 closed Bug (fixed)
[Webkit] Undo manager records snapshots after filling char has been removed/added
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.1.1 |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description
This affects undoM.save() but also lock()/unlock().
Change History (6)
comment:1 Changed 12 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | new → assigned |
comment:2 Changed 12 years ago by
| Status: | assigned → review |
|---|
comment:3 Changed 12 years ago by
Pushed t/10315b on dev and updated tests to t/10315b.
During working on #10291 I found that there already exists code that should hide filling char when creating snapshot image. So I reused existing functionality of image in lock/unlock.
However, that wasn't the only issue. It turned out that code that should invalidate filling char caches editable instance and stops working after editable is replaced by new one. I fixed that too.
comment:5 Changed 12 years ago by
| Status: | review → review_passed |
|---|
comment:6 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed on master with git:24a7ca4 on dev and 65cc722 on tests.
Note: See
TracTickets for help on using
tickets.
Pushed t/10315 on dev and tests.
Branches are based on #10131 which should be reviewed first.