fillEmptyBlocks not working properly if a function is specified

[raz_atoth]

The function never fires,if config.fillEmptyBlocks is a function,although there are empty elements and a &nbsp; is placed instead just as if config.fillEmptyBlocks was true [<div class="block">&nbsp;</div>] If config.fillEmptyBlocks=false it works as expected [<div class="block"></div>]

config.fillEmptyBlocks = function( element )
	{
		alert('fillEmptyBlocks!');
		if ( element.attributes[ 'class' ].indexOf ( 'clear-both' ) != -1 )
			return false;
	}

[Jakub Ś]

Problem can be reproduced from CKEditor 4 beta. In 3.x branch when you switched to source you could see alert being called. Nothing like this is happening in CKE 4.x.

[casupport]

For CKEditor 4.3.1 in htmldataprocessor.js, it appears the fillEmptyBlock argument for blockFilter() will always be passed as a boolean true when config.fillEmptyBlocks is a function. So when building the list of text blocks, blockFilter() will never receive a function for the fillEmptyBlock argument. Propose changes:

From

for ( i in textBlockTags )
rules.elements[ i ] = blockFilter( isOutput, editor.config.fillEmptyBlocks !== false );

To

for ( i in textBlockTags )
rules.elements[ i ] = blockFilter( isOutput, editor.config.fillEmptyBlocks );

And From

( typeof fillEmptyBlock == 'function' ? fillEmptyBlock( block ) !== false : fillEmptyBlock ) ) 

To

( typeof fillEmptyBlock == 'function' ? fillEmptyBlock( block ) !== false : fillEmptyBlock !== false ) ) 

[Piotrek Koszuliński]

A duplicate was reported in #12129.

[Piotrek Koszuliński]

Pushed ​branch:t/10422.

[Marek Lewandowski]

I've updated one comment and joined var statement. Fixed with ​git:ab195efbe1 (merged to master).