Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12129 closed Bug (duplicate)

config.fillEmptyBlocks does not accept callback

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

This needs to be investigated. In 3.5 (#5404), when option was introduced it has been accepting callback. Then, at some point this change was made:

blockFilter( isOutput, editor.config.fillEmptyBlocks !== false );

And it's obviously wrong now. However, at some point also docs have been modified and the type of this setting is now Boolean (no Function). So perhaps it was an intentional change. In such case we should fix docs, not code.

Change History (3)

comment:1 Changed 5 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 5 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: confirmedassigned

comment:3 Changed 5 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.4.3
Resolution: duplicate
Status: assignedclosed

Issue was introduced in git:ea074195, when porting v3 changes to v4. Therefore I assume that fillEmptyBlocks should still accept functions. It also turned out that this ticket is a DUP of #10422.

Last edited 5 years ago by Piotrek Koszuliński (previous) (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy