Opened 8 years ago

Closed 7 years ago

#5404 closed New Feature (fixed)

FillEmptyBlocks in CKEditor 3.x

Reported by: Wiktor Walc Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5
Component: Core : Output Data Version:
Keywords: Cc:

Description

It looks like FillEmptyBlocks option is not available in CKEditor 3.x, thus it is impossible to configure CKEditor to leave empty elements without nbsp; inside of it.

Attachments (5)

5404.patch (3.4 KB) - added by Garry Yao 8 years ago.
5404_2.patch (3.7 KB) - added by Garry Yao 7 years ago.
5404_3.patch (4.3 KB) - added by Garry Yao 7 years ago.
5404_4.patch (4.3 KB) - added by Garry Yao 7 years ago.
5404_5.patch (4.3 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (20)

Changed 8 years ago by Garry Yao

Attachment: 5404.patch added

comment:1 Changed 8 years ago by Garry Yao

Component: GeneralCore : Output Data
Keywords: Confirmed Review? added
Milestone: CKEditor 3.4
Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4CKEditor 3.5

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4.1CKEditor 3.5

Changed 7 years ago by Garry Yao

Attachment: 5404_2.patch added

comment:4 Changed 7 years ago by Garry Yao

Status: reviewassigned

With the new patch, fillEmptyBlocks config could be even a mediate function that allows fully controlling over empty blocks (a community feature request).

comment:5 Changed 7 years ago by Garry Yao

Status: assignedreview

comment:6 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed
  • This setting bus be enabled by default.
  • The documentation syntax is wrong (@type doesn't accept description and there is semicolon after @name).

comment:7 Changed 7 years ago by Frederico Caldeira Knabben

Btw... the fix is targeted to the 3.5, but it looks like the patch has been made for trunk.

comment:8 Changed 7 years ago by Frederico Caldeira Knabben

Also... better to commit #6248 and update the 3.5.x branch before the new patch, to avoid conflicts later.

Changed 7 years ago by Garry Yao

Attachment: 5404_3.patch added

comment:9 Changed 7 years ago by Garry Yao

Status: review_failedreview
Version: 3.0

comment:10 Changed 7 years ago by Sa'ar Zac Elias

Keywords: Confirmed removed
Status: reviewreview_passed

Two minor things:

  • L517 could be removed.
  • Let's add to the documentation the fact that we're passing our CKEDITOR.htmlParser.element representation there, and not CKEDITOR.dom.element.

Changed 7 years ago by Garry Yao

Attachment: 5404_4.patch added

comment:11 Changed 7 years ago by Garry Yao

Status: review_passedreview

comment:12 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_failed

Using following content:

<p>
	foo</p>
<p>
	&nbsp;</p>
<p>
	bar</p>

Second paragraph is not visible and thus not editable inside WYSIWYG area.

Changed 7 years ago by Garry Yao

Attachment: 5404_5.patch added

comment:13 Changed 7 years ago by Garry Yao

Status: review_failedreview

You're right, this option should have NO impact on wysiwyg.

comment:14 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_passed

It's OK now, just change the example inside the JSDOC comment, as it causes an error for elements without a class.

comment:15 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6138].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy