Opened 15 years ago
Closed 14 years ago
#5404 closed New Feature (fixed)
FillEmptyBlocks in CKEditor 3.x
| Reported by: | Wiktor Walc | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5 |
| Component: | Core : Output Data | Version: | |
| Keywords: | Cc: |
Description
It looks like FillEmptyBlocks option is not available in CKEditor 3.x, thus it is impossible to configure CKEditor to leave empty elements without nbsp; inside of it.
Attachments (5)
Change History (20)
Changed 15 years ago by
| Attachment: | 5404.patch added |
|---|
comment:1 Changed 15 years ago by
| Component: | General → Core : Output Data |
|---|---|
| Keywords: | Confirmed Review? added |
| Milestone: | → CKEditor 3.4 |
| Owner: | set to Garry Yao |
| Status: | new → assigned |
comment:2 Changed 14 years ago by
| Milestone: | CKEditor 3.4 → CKEditor 3.5 |
|---|
comment:3 Changed 14 years ago by
| Milestone: | CKEditor 3.4.1 → CKEditor 3.5 |
|---|
Changed 14 years ago by
| Attachment: | 5404_2.patch added |
|---|
comment:4 Changed 14 years ago by
| Status: | review → assigned |
|---|
comment:5 Changed 14 years ago by
| Status: | assigned → review |
|---|
comment:6 Changed 14 years ago by
| Status: | review → review_failed |
|---|
- This setting bus be enabled by default.
- The documentation syntax is wrong (@type doesn't accept description and there is semicolon after @name).
comment:7 Changed 14 years ago by
Btw... the fix is targeted to the 3.5, but it looks like the patch has been made for trunk.
comment:8 Changed 14 years ago by
Also... better to commit #6248 and update the 3.5.x branch before the new patch, to avoid conflicts later.
Changed 14 years ago by
| Attachment: | 5404_3.patch added |
|---|
comment:9 Changed 14 years ago by
| Status: | review_failed → review |
|---|---|
| Version: | 3.0 |
comment:10 Changed 14 years ago by
| Keywords: | Confirmed removed |
|---|---|
| Status: | review → review_passed |
Two minor things:
- L517 could be removed.
- Let's add to the documentation the fact that we're passing our CKEDITOR.htmlParser.element representation there, and not CKEDITOR.dom.element.
Changed 14 years ago by
| Attachment: | 5404_4.patch added |
|---|
comment:11 Changed 14 years ago by
| Status: | review_passed → review |
|---|
comment:12 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Using following content:
<p> foo</p> <p> </p> <p> bar</p>
Second paragraph is not visible and thus not editable inside WYSIWYG area.
Changed 14 years ago by
| Attachment: | 5404_5.patch added |
|---|
comment:13 Changed 14 years ago by
| Status: | review_failed → review |
|---|
You're right, this option should have NO impact on wysiwyg.
comment:14 Changed 14 years ago by
| Status: | review → review_passed |
|---|
It's OK now, just change the example inside the JSDOC comment, as it causes an error for elements without a class.
comment:15 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6138].
Note: See
TracTickets for help on using
tickets.
With the new patch, fillEmptyBlocks config could be even a mediate function that allows fully controlling over empty blocks (a community feature request).