Opened 5 years ago

Closed 5 years ago

#12130 closed Bug (fixed)

Bender.tools.range.getWithHtml prunes element ids

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.4.3
Component: General Version:
Keywords: Cc:

Description

Because of

https://github.com/benderjs/benderjs-ckeditor/blob/cdd10213ec748101f0e3d9eead8da01fb8f04245/static/tools.js#L1108

and

https://github.com/benderjs/benderjs-ckeditor/blob/cdd10213ec748101f0e3d9eead8da01fb8f04245/static/tools.js#L1069 (IE),

element ids are pruned. This is the default behavior of CKEDITOR.dom.node.clone(), which is undesired in bender.tools.range.getWithHtml().

Change History (6)

comment:1 Changed 5 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newassigned

comment:2 Changed 5 years ago by Olek Nowodziński

Status: assignedreview

comment:3 Changed 5 years ago by Piotrek Koszuliński

Status: reviewreview_failed

CKEDITOR.dom.node#clone accepts a 2nd parameter - cloneId ;)

comment:4 in reply to:  3 Changed 5 years ago by Olek Nowodziński

Status: review_failedreview

Replying to Reinmar:

CKEDITOR.dom.node#clone accepts a 2nd parameter - cloneId ;)

Right. Fixed in 12130b: https://github.com/benderjs/benderjs-ckeditor/commit/3f1275b0b3e4e323265e0d0cf3a7ef18395e1c0d.

comment:5 Changed 5 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.4.3
Status: reviewreview_passed

Pushed branch:t/12130 rebased on master - it was incorrectly rooted in major.

comment:6 Changed 5 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy