Opened 6 years ago

Closed 6 years ago

#10505 closed Bug (fixed)

[IE7] Manual test for #10165 fails when editor built from preset

Reported by: Olek Nowodziński Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 4.1.2
Component: General Version: 4.1.2
Keywords: Cc:

Description

Test for #10165 is: http://ckeditor4.t/mt/4.1.2/10165.html

If the editor is based on the full preset (./build.sh full all) with or without --leave-js-unminified, IE7 raises Permission Denied errors when accessing link dialog or clipboard paste dialog.

It passes on dev code though.

Change History (6)

comment:1 Changed 6 years ago by Frederico Caldeira Knabben

I've just played with the IE console in a test page with custom domain. You gonna love this:

>> CKEDITOR.document.getWindow().$ == window 
true 

>> CKEDITOR.document.getWindow().$.document 
"Access is denied."

>> window.document 
[object] { … }

It turned out that we save a reference to window inside CKEDITOR.document, which is actually a object reference different that "window" at a later stage. In fact, we have this as well:

>> CKEDITOR.document.getWindow().$ === window 
false

So basically, in IE, an old reference to "window" may be different than "window".

Welcome to the world of IE!

comment:2 Changed 6 years ago by Frederico Caldeira Knabben

Owner: set to Frederico Caldeira Knabben
Status: newreview

I've just pushed a fix for this in t/10505. I'm simply avoiding caching "window", as it is mutable. I doubt we would have performance issues because of this.

comment:3 Changed 6 years ago by Piotrek Koszuliński

You gonna love this

Yes, I am :D

comment:4 in reply to:  1 Changed 6 years ago by Olek Nowodziński

Replying to fredck:

I've just played with the IE console in a test page with custom domain. You gonna love this:

>> CKEDITOR.document.getWindow().$ == window 
true 

>> CKEDITOR.document.getWindow().$.document 
"Access is denied."

>> window.document 
[object] { … }

It turned out that we save a reference to window inside CKEDITOR.document, which is actually a object reference different that "window" at a later stage. In fact, we have this as well:

>> CKEDITOR.document.getWindow().$ === window 
false

So basically, in IE, an old reference to "window" may be different than "window".

Welcome to the world of IE!

I assume that the error is because there are few files to be loaded in the package and hence things go too fast?

comment:5 Changed 6 years ago by Olek Nowodziński

Status: reviewreview_passed

Tests don't confirm the expected performance loss. This fix is sufficient.

comment:6 Changed 6 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Merged fix into master, dev (​git:8f4b94b).

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy