Opened 4 years ago

Last modified 3 years ago

#10631 confirmed Bug

Content Advisor in IE8 Causes 4.1.2 to not function

Reported by: Jared Dutton Owned by:
Priority: Normal Milestone:
Component: General Version: 4.1.2
Keywords: IE8 IBM Cc: satya_minnekanti@…, irinauru@…

Description

When Content Advisor is turned on in IE8, regardless of the restrictiveness of the filtering options, CKEditor will not go into an editable state or enable any of the buttons.

I have validated this using the CKEditor Samples > Replace Textarea Elements by Class name. It works properly in 4.1.1.

Attachments (1)

plugin.js (23.3 KB) - added by Jared Dutton 4 years ago.
Modified plugins/wysiwygarea/plugin.js

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by Jared Dutton

Keywords: content advisor ie8 removed

Steps to Reproduce:

  1. Start IE8
  2. Tools -> Internet Options -> Content tab
  3. Content Advisor -> Settings -> General tab
  4. Make sure Users can see websites that have no rating and Supervisor can type a password to allow users to view restricted content are checked. Press OK
  5. Click Content Advisor -> Enable
  6. Go to 4.1.2 (or nightly) build and view CKEditor

comment:2 Changed 4 years ago by Jakub Ś

Keywords: IE8 added
Status: newconfirmed

Problem can be reproduced from CKEditor 4.1.2 and only in IE8.

All you have to do is turn on content advisor and reload page. CKEditor will show up with buttons disabled and no content. You can click on dropdowns but you will only get "hasFocus or this.getSelection is null or not an object" error.

Changed 4 years ago by Jared Dutton

Attachment: plugin.js added

Modified plugins/wysiwygarea/plugin.js

comment:3 Changed 4 years ago by Jared Dutton

Please disregard file, it included some modifications in it that I left in. Found a workaround. Modified line 73 of plugins/wysiwygarea/plugin.js to:

onLoad();

from:

!useOnloadEvent && onLoad();

This will cause the onLoad to get called twice in IE without Content Advisor, but gets it working with Content Advisor (and keeps our clients happy for now).

Side note that may help with debugging: Line 24 of the same file (plugins/wysiwygarea/plugin.js), the call to CKEDITOR.tools.fixDomain seems to be the cause of Content Advisor not working, but removing it causes IE to stop working for non Content Advisor usage.

Sorry for the messy comment :-S.

comment:4 Changed 3 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added

comment:5 Changed 3 years ago by Irina

Cc: irinauru@… added
Keywords: IBM added

comment:6 Changed 3 years ago by Irina

Any updates regarding this ticket? This is still an issue in 4.4.6 and its a high priority for us as this was reported by one of our customers.

comment:7 Changed 3 years ago by Piotrek Koszuliński

I've checked the solution proposed by @jaredaz and it indeed makes the editor work with Content Advisory. Unfortunately, editor starts throwing errors in normal mode, so additional check is needed in onLoad. I pushed a prototype of fix in branch:t/10631.

Unfortunately, this part of code is crucial for editor and also, as we could see (now and in the past), deals with a pretty unstable environment. A patch will require far more work and tests. Also, I've already run some tests on IE8 with Content Advisory on and many of them failed, so it's hard to say yet whether the fix really works and doesn't break something else.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy