Opened 6 years ago

Closed 5 years ago

#10708 closed Task (fixed)

New smileys

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.3 Beta
Component: General Version: 4.3 Beta
Keywords: Cc:

Description (last modified by Olek Nowodziński)

We're gonna definitely cut off from the past by bringing new smileys.

Attachments (1)

newsmileys.png (20.6 KB) - added by Olek Nowodziński 6 years ago.

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by Olek Nowodziński

Attachment: newsmileys.png added

comment:1 Changed 6 years ago by Olek Nowodziński

Description: modified (diff)

comment:2 Changed 6 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newreview

Created branch t/10708 with new smileys.

comment:3 Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

Moving to png is a great idea.

Unfortunately we cannot simply delete the old gifs as it'll result on braking compatibility with previously created contents. So we'll have to have the gifs in place as well.

comment:4 in reply to:  3 Changed 5 years ago by Olek Nowodziński

Status: review_failedreview

Replying to fredck:

Moving to png is a great idea.

Unfortunately we cannot simply delete the old gifs as it'll result on braking compatibility with previously created contents. So we'll have to have the gifs in place as well.

  • I added GIFs corresponding with new smileys.
  • I also added two misspelled smileys that we had because of backwards compatibility (embaressed_smile.gif, tounge_smile.gif: fixed in git:47aec1a7c0e926a8a).

comment:5 Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:6 Changed 5 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Merged into major in git:9b0267e.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy