Opened 11 years ago
Closed 11 years ago
#10708 closed Task (fixed)
New smileys
Reported by: | Olek Nowodziński | Owned by: | Olek Nowodziński |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.3 Beta |
Component: | General | Version: | 4.3 Beta |
Keywords: | Cc: |
Description (last modified by )
Attachments (1)
Change History (7)
Changed 11 years ago by
Attachment: | newsmileys.png added |
---|
comment:1 Changed 11 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 11 years ago by
Owner: | set to Olek Nowodziński |
---|---|
Status: | new → review |
comment:3 follow-up: 4 Changed 11 years ago by
Status: | review → review_failed |
---|
Moving to png is a great idea.
Unfortunately we cannot simply delete the old gifs as it'll result on braking compatibility with previously created contents. So we'll have to have the gifs in place as well.
comment:4 Changed 11 years ago by
Status: | review_failed → review |
---|
Replying to fredck:
Moving to png is a great idea.
Unfortunately we cannot simply delete the old gifs as it'll result on braking compatibility with previously created contents. So we'll have to have the gifs in place as well.
- I added GIFs corresponding with new smileys.
- I also added two misspelled smileys that we had because of backwards compatibility (embaressed_smile.gif, tounge_smile.gif: fixed in git:47aec1a7c0e926a8a).
comment:5 Changed 11 years ago by
Status: | review → review_passed |
---|
comment:6 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Merged into major in git:9b0267e.
Created branch t/10708 with new smileys.