cke 4.2 selectall plugin breaks codemirror plugin

[Chris Cohen]

Line 32 of selectall plugin needs to be changed to

if (editable.isVisible( )) editable.focus();

[Jakub Ś]

cke 4.2 selectall plugin breaks codemirror plugin

1. It isn't CKEditor that needs to adjust to third-party plugins but third-party plugins to editor.
2. Plugin ​http://ckeditor.com/addon/codemirror has no confirmed support for version 4.2.

You should rather inform plugin author about this.

I'm invalidating this ticket but in order to exclude any possibility that there is something broken in editor please explain exactly in step by step scenario what is happening and why this line needs to be changed. This is important as “please fix this line” is just not enough information.

[Chris Cohen]

Plugin author has been informed, but I think this is a regression in selectall plugin.

On stepping through I can see that the codemirror correctly overrides the selectall button exec but when control returns to the selectall plugin it attempts to focus on an element that has been hidden and so an error is thrown.

[Piotrek Koszuliński]

So the codemirror DOES NOT correctly override selectall if it allows to focus invisible element. CKEditor's code cannot foreseen every possible case produced by overriding its normal behaviours.

Conclusion: Codemirror plugin needs to be fixed.

[Chris Cohen]

On further investigation it appears that the focus method:

			focus: function() {
				// [IE] Use instead "setActive" method to focus the editable if it belongs to
				// the host page document, to avoid bringing an unexpected scroll.
				this.$[ CKEDITOR.env.ie && this.getDocument().equals( CKEDITOR.document ) ? 'setActive' : 'focus' ]();

needs to be sensitive to IE version - 9 and 10 provoke 'Incorrect function' using 'setActive' whereas 'focus' is ok - versions 7 and 8 are ok with setActive.

[Piotrek Koszuliński]

If you think that there's an issue in that code, please report a ticket which exemplifies it. This one was about a bug in Codemirror, so there's no example of correct usage of CKEditor which causes an issue.

[Jakub Ś]

What @Reinmar means is that you should report new ticket which besides solution shows situation where things go wrong and for which this solution can be applied.