Opened 6 years ago

Closed 5 years ago

#10823 closed Bug (fixed)

Link plugin fails when applied to a non-editable content

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Must have (possibly next milestone) Milestone: CKEditor 4.3
Component: General Version:
Keywords: Cc:

Description (last modified by Piotrek Koszuliński)

In link/dialogs/link.js:

				var range = selection.getRanges( 1 )[ 0 ];

				// Use link URL as text with a collapsed cursor.
				if ( range.collapsed ) {

These lines cause problem, because ranges is an empty array if only widget (non-editable content) is selected.

Change History (7)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Description: modified (diff)
Status: newconfirmed
Summary: Link plugin fails when applied to non-editable contentLink plugin fails when applied to a non-editable content

comment:2 Changed 6 years ago by Piotrek Koszuliński

Priority: NormalHigh

comment:3 Changed 6 years ago by Piotrek Koszuliński

I think that #10822 should go before this ticket. After we'll fix applying styles on non-editable elements, we will be able to just get a full range (currently only the editable part is extracted, which in case of widget selection is empty) from selection and apply link's style on it.

comment:4 Changed 5 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: confirmedassigned

comment:5 Changed 5 years ago by Piotrek Koszuliński

Status: assignedreview

Pushed t/10823 on dev and test. This patch fixes the selection problems.

I reported separate tickets for: #11037, #11038 and #11039.

comment:6 Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:7 Changed 5 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Fixed on major with git:fc83fe7 on dev and a8bfc0c on tests.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy