Opened 6 years ago

Closed 5 years ago

#10833 closed Bug (fixed)

Image2: “Lock ratio” should be on by default.

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.3
Component: General Version: 4.3 Beta
Keywords: Cc:

Change History (14)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Status: newconfirmed

comment:2 Changed 5 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmedassigned

comment:3 Changed 5 years ago by Olek Nowodziński

Status: assignedreview

Created branch t/10833 with 1LOC fix.

comment:4 Changed 5 years ago by Piotrek Koszuliński

Status: reviewreview_failed
  1. Doubleclick on image, disable the "lock ratio" option.
  2. Change size of an image to unproportional and close dialog.
  3. Doubleclick on image again to open dialog.
  • Expected: since unproportional size is set the "lock ration" option should be disabled.
  • Actual: "lock ratio" is enabled.

This works on image plugin.

comment:5 Changed 5 years ago by Olek Nowodziński

Status: review_failedreview

comment:6 Changed 5 years ago by Piotrek Koszuliński

Status: reviewreview_passed

comment:7 Changed 5 years ago by Piotrek Koszuliński

Status: review_passedreview_failed

Oups. It turned out that this patch introduced #10958.

comment:8 Changed 5 years ago by Olek Nowodziński

Status: review_failedreview

Updated dev branch:

  • Fixed #10958.
  • Introduced widget.data.lock.
  • Introduced shared helper functions checkHasNaturalRatio and getNatural.
  • Bypassed lack of support for $.natural(Width|Height) in IE8 with CKEDITOR.plguins.image2.getNatural

comment:9 in reply to:  8 ; Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

Replying to a.nowodzinski:

Updated dev branch:

  • Fixed #10958.
  • Introduced widget.data.lock.
  • Introduced shared helper functions checkHasNaturalRatio and getNatural.
  • Bypassed lack of support for $.natural(Width|Height) in IE8 with CKEDITOR.plguins.image2.getNatural

:/ I don't see anything of this in t/10833 ???

comment:10 in reply to:  9 Changed 5 years ago by Olek Nowodziński

Status: review_failedreview

Replying to fredck:

:/ I don't see anything of this in t/10833 ???

My fault. I've just pushed the code to that branch.

comment:11 Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

I see that the lock ratio behavior is much better now. It's a good improvement.

Buuuut… there is still an important issue, especially when you read the ticket title which says "“Lock ratio” should be on by default"…. when you open the image2 dialog to insert a new image, the lock thing is "off", instead of being "on"… by default.

Let's have this last missing thing dealt as well

comment:12 in reply to:  11 Changed 5 years ago by Olek Nowodziński

Status: review_failedreview

Replying to fredck:

I see that the lock ratio behavior is much better now. It's a good improvement.

Buuuut… there is still an important issue, especially when you read the ticket title which says "“Lock ratio” should be on by default"…. when you open the image2 dialog to insert a new image, the lock thing is "off", instead of being "on"… by default.

Let's have this last missing thing dealt as well

Yeah. I fixed everything except what this ticket is about :P

Pushed a commit to dev branch and rebased on latest major.

comment:13 Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:14 Changed 5 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Branch merged into major: git:d792be6

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy