Opened 6 years ago

Closed 6 years ago

#10881 closed Bug (fixed)

Widget System does not fix active enter modes if blockless nested editable is focused

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.3
Component: General Version: 4.3 Beta
Keywords: Cc:

Description

Active enter modes are only affected by the nested editable's ACF rules. Currently the enter key works correctly because it internally checks blocksLimit, but this should be driven by the active enter mode change.

Change History (5)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Status: newconfirmed

comment:2 Changed 6 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: confirmedassigned

comment:3 Changed 6 years ago by Piotrek Koszuliński

Status: assignedreview

Pushed t/10881 branches on dev and tests.

This branch fixes:

  • this issue - enter mode is set to BR in blockless nested editables,
  • #10880 - when setting active filter the default enter mode will be checked in the first place and then the rest,
  • #10938 - the data-cke-enter-mode attribute allows to read in which enter mode editable work without knowing anything about widgets (was blocking #10828).

comment:4 Changed 6 years ago by Olek Nowodziński

Status: reviewreview_passed

Every time you resolve 3 tickets in a single commit, a bunch of sinister, eyeless bunnies visits you at night to watch you sleep. Brace yourself. ♥

comment:5 Changed 6 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Merged fix into major, dev (​git:628ea19), tests (62812ce).

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy