Magicline icon is not mirrored in RTL environments

[Teresa Monahan]

To Reproduce:

• Open the uiLanguages sample and select an RTL language from the dropdown e.g. Arabic
• Insert a table at the start of the editor
• Hover above the editor so that the magicline UI is displayed.

Problem: The icon is not mirrored for RTL languages.

The following code is from magicline/plugin.js. As you can see there is no support for loading a different icon for rtl/ltr languages:

iconPath = this.path + 'images/' + ( env.hidpi ? 'hidpi/' : '' ) + 'icon.png';

[Jakub Ś]

I confirm this - icon shows on left side (correct) but it isn't mirrored.

[Christophe Guillou]

Hi, just checking if that's something we can get fixed for the next release? To what I can see in the source, the fix is very straightforward, we would just need to add some more logic in

L571:

iconPath = this.path + 'images/' + ( env.hidpi ? 'hidpi/' : ) + 'icon.png';

to select the 'mirrored icon' based on the rtl setting (using: that.rtl)

Can you please give us an update if that's realistic get this incorporated for the next milestone?

[Olek Nowodziński]

Pushed fix to ​branch:t/10916.

[Piotrek Koszuliński]

On IE9 there's a black background created by the filter. The arrow has round borders so the background is visible there.

[Olek Nowodziński]

Replying to Reinmar:

On IE9 there's a black background created by the filter. The arrow has round borders so the background is visible there.

Yeah, I know about it but I decided that it's OK considering the simplicity of solution and small market share.

[Piotrek Koszuliński]

I see no problems with the second icon file and if we are doing anything, let's do it right.

[Olek Nowodziński]

​branch:t/10916b

[Marek Lewandowski]

Good job, fixed with ​git:67433b0695 (merged to master) at dev.