Opened 10 years ago
Closed 10 years ago
#10936 closed Task (fixed)
Widget System changes for easier integration with other dialog system
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3 |
| Component: | UI : Widgets | Version: | 4.3 Beta |
| Keywords: | Drupal | Cc: |
Description
- Currently we're finalizing (inserting into document and setting ready flag) widget creation internally, but this code needs to be reused when widget is integrated with other dialog system.
- It's not possible now to postpone automatic widget insertion if widget#edit event is blocked. In Drupal's case this should be postponed until its dialog is closed.
Change History (6)
comment:1 Changed 10 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | new → assigned |
comment:2 Changed 10 years ago by
| Type: | Bug → Task |
|---|
comment:3 Changed 10 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 10 years ago by
| Status: | review → review_passed |
|---|
Rebased both branches. Pushed a single commit to dev with a minor fix to docs.
comment:5 Changed 10 years ago by
Your commit is incorrect ;> In AmE there's "canceled". "Cancelled" is used in BrE.
comment:6 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed on major with git:0e3084a and tests with 45f14f9.
Note: See
TracTickets for help on using
tickets.
Pushed t/10936 on dev and tests.