Opened 6 years ago

Closed 6 years ago

#10936 closed Task (fixed)

Widget System changes for easier integration with other dialog system

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.3
Component: UI : Widgets Version: 4.3 Beta
Keywords: Drupal Cc:

Description

  1. Currently we're finalizing (inserting into document and setting ready flag) widget creation internally, but this code needs to be reused when widget is integrated with other dialog system.
  2. It's not possible now to postpone automatic widget insertion if widget#edit event is blocked. In Drupal's case this should be postponed until its dialog is closed.

Change History (6)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newassigned

comment:2 Changed 6 years ago by Piotrek Koszuliński

Type: BugTask

comment:3 Changed 6 years ago by Piotrek Koszuliński

Status: assignedreview

Pushed t/10936 on dev and tests.

comment:4 Changed 6 years ago by Olek Nowodziński

Status: reviewreview_passed

Rebased both branches. Pushed a single commit to dev with a minor fix to docs.

comment:5 Changed 6 years ago by Piotrek Koszuliński

Your commit is incorrect ;> In AmE there's "canceled". "Cancelled" is used in BrE.

comment:6 Changed 6 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Fixed on major with git:0e3084a and tests with 45f14f9.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy