Opened 5 years ago

Closed 5 years ago

#11081 closed Task (fixed)

JSLint 4.3

Reported by: Olek Nowodziński Owned by:
Priority: Normal Milestone: CKEditor 4.3
Component: General Version:
Keywords: Cc:

Description

For a better world.

Change History (8)

comment:1 Changed 5 years ago by Olek Nowodziński

Status: newconfirmed

comment:2 Changed 5 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: confirmedassigned

comment:3 Changed 5 years ago by Piotr Jasiun

Status: assignedreview

There were a mess in style.removeFromInsideElement function. I fixed it based on master version, but please check in again during review. That is a shame that there are no tests checking if it works properly.

A also added some missing semicolons and added Image and $ to global definitions.

Last edited 5 years ago by Piotr Jasiun (previous) (diff)

comment:4 Changed 5 years ago by Olek Nowodziński

Status: reviewreview_failed

What's the point of fixing JSLint issues when still some tickets are pending? This got to be done once everything is merged into major, right before testing phase.

comment:5 Changed 5 years ago by Piotr Jasiun

Status: review_failedreview

Maybe I was not enough clear. I want someone check changes in style.removeFromInsideElement. After that I will put this ticket again in 'assigned'.

comment:6 Changed 5 years ago by Piotr Jasiun

Status: reviewassigned

comment:7 Changed 5 years ago by Piotr Jasiun

Owner: Piotr Jasiun deleted
Status: assignedconfirmed

comment:8 Changed 5 years ago by Piotrek Koszuliński

Resolution: fixed
Status: confirmedclosed

Fixed on major with git:b118c02.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy