#11086 closed New Feature (fixed)
[IE8] Re enable inline widgets DnD
| Reported by: | Piotrek Koszuliński | Owned by: | Piotr Jasiun |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3.2 |
| Component: | General | Version: | 4.3 |
| Keywords: | IE8 IE | Cc: |
Description (last modified by )
Change History (11)
comment:1 Changed 11 years ago by
| Description: | modified (diff) |
|---|---|
| Status: | new → confirmed |
comment:2 Changed 11 years ago by
| Milestone: | CKEditor 4.3.1 → CKEditor 4.3.2 |
|---|
comment:3 Changed 11 years ago by
| Owner: | set to Piotr Jasiun |
|---|---|
| Status: | confirmed → assigned |
comment:4 Changed 11 years ago by
| Status: | assigned → review |
|---|
comment:5 Changed 11 years ago by
It doesn't make sense to spend time on reviewing this ticket before we know how to fix #11158, because it may turn out that we'll have to rewrite dnd anyway.
comment:6 Changed 11 years ago by
| Status: | review → review_failed |
|---|
Everything works fine when testing manually, but widget tests fail on IE8.
comment:7 Changed 11 years ago by
I forgot to mention that I rebased both branches and force pushed them.
These tests are failing:
/dt/plugins/widget/widgetsintegration.html#test pasting upcasted widgets[[BR]] /dt/plugins/widget/widgetsrepoapi.html#test widgets.destroy[[BR]] /dt/plugins/widget/widgetsrepoapi.html#test widgets.checkWidgets draghandler re usage[[BR]] /dt/plugins/widget/undo.html#test d&d inline widget
comment:8 Changed 11 years ago by
| Status: | review_failed → review |
|---|
A rebased both branches and fixed tests.
comment:9 Changed 11 years ago by
| Status: | review → review_failed |
|---|
Block widgets dnd does not work now on IE8. It behaves like inline dnd but nothing happens.
comment:10 Changed 11 years ago by
| Status: | review_failed → review_passed |
|---|
I pushed a fix for issue mentioned in comment:9. Everything works fine now.
comment:11 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
- git:0016523
- tests:ae905e6
Note: See
TracTickets for help on using
tickets.
After re enable D&D works fine on IE8 (without error). It looks that git:6e1cc76 fixed also IE8 issue. Changes in t/11086 and corresponding test branch.