Opened 5 years ago

Last modified 5 years ago

#11114 confirmed Bug

Unable to access context menu with menu key when widget is focused

Reported by: Olek Nowodziński Owned by:
Priority: Normal Milestone:
Component: UI : Context Menu Version: 4.3 Beta
Keywords: Cc:

Description

  1. samples/plugins/image2/image2.html
  2. Focus widget.
  3. Press menu key.
  4. Nothing happens.

Both right-click and CTRL+SHIFT+F10 work as expected.

Change History (7)

comment:1 Changed 5 years ago by Piotr Jasiun

Status: newconfirmed

comment:2 Changed 5 years ago by Marek Lewandowski

Note: that menu button does work correctly for FF, IE10 (at least WFM)

comment:3 Changed 5 years ago by Marek Lewandowski

Owner: set to Marek Lewandowski
Status: confirmedassigned

comment:4 Changed 5 years ago by Marek Lewandowski

Status: assignedreview

at the begining there was binding only for webkit, the only one thing which it was doing for webkit was changing holdCtrlKey value to 1 or 0 i've moved webkit condition to the place where this value might be changed to 1, to avoid changing the logic

code is a little complex since i wanted to cover both framed editor and inline one - and avoid errors like outflowing when editor is scrolled

i made no changes do IE, since it was positioning menu key

commited to dev t/11114

comment:5 Changed 5 years ago by Piotrek Koszuliński

Owner: changed from Marek Lewandowski to Piotrek Koszuliński
Status: reviewassigned

It's far too complex solution and it does not work ;).

  1. Nothing opens on Chrome on Linux (contextmenu event goes before keydown I suppose).
  2. Positioning does not work.
  3. It's not so important case to waste 40LOC for it. Especially that apparently it's still not enough.

comment:6 Changed 5 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.3.1
Owner: Piotrek Koszuliński deleted
Status: assignedconfirmed

I spent on this ticket few hours and this is enough. There are no consistency at all between browsers and OSes too. I could not even find out whether contextmenu was triggered by right click or option key because listening on keydown does not help (contextmenu is fired before keydown).

I pushed t/11114b with some ideas, but it's a dead end in my opinion. We need complex review of contextmenu, so we'll have a stable and good solution for positioning menu when the native positioning fails.

I'm postponing this ticket, but part of t/11114b is a cleanup and docs, so I'll masterise it now, because these are good changes.

comment:7 Changed 5 years ago by Piotrek Koszuliński

Cleanup merged to master with git:bace56b.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy