Opened 11 years ago
Last modified 11 years ago
#11114 confirmed Bug
Unable to access context menu with menu key when widget is focused
Reported by: | Olek Nowodziński | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | UI : Context Menu | Version: | 4.3 Beta |
Keywords: | Cc: |
Description
- samples/plugins/image2/image2.html
- Focus widget.
- Press menu key.
- Nothing happens.
Both right-click and CTRL+SHIFT+F10 work as expected.
Change History (7)
comment:1 Changed 11 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 11 years ago by
comment:3 Changed 11 years ago by
Owner: | set to Marek Lewandowski |
---|---|
Status: | confirmed → assigned |
comment:4 Changed 11 years ago by
Status: | assigned → review |
---|
at the begining there was binding only for webkit, the only one thing which it was doing for webkit was changing holdCtrlKey
value to 1 or 0
i've moved webkit condition to the place where this value might be changed to 1, to avoid changing the logic
code is a little complex since i wanted to cover both framed editor and inline one - and avoid errors like outflowing when editor is scrolled
i made no changes do IE, since it was positioning menu key
commited to dev t/11114
comment:5 Changed 11 years ago by
Owner: | changed from Marek Lewandowski to Piotrek Koszuliński |
---|---|
Status: | review → assigned |
It's far too complex solution and it does not work ;).
- Nothing opens on Chrome on Linux (contextmenu event goes before keydown I suppose).
- Positioning does not work.
- It's not so important case to waste 40LOC for it. Especially that apparently it's still not enough.
comment:6 Changed 11 years ago by
Milestone: | CKEditor 4.3.1 |
---|---|
Owner: | Piotrek Koszuliński deleted |
Status: | assigned → confirmed |
I spent on this ticket few hours and this is enough. There are no consistency at all between browsers and OSes too. I could not even find out whether contextmenu was triggered by right click or option key because listening on keydown does not help (contextmenu is fired before keydown).
I pushed t/11114b with some ideas, but it's a dead end in my opinion. We need complex review of contextmenu, so we'll have a stable and good solution for positioning menu when the native positioning fails.
I'm postponing this ticket, but part of t/11114b is a cleanup and docs, so I'll masterise it now, because these are good changes.
Note: that menu button does work correctly for FF, IE10 (at least WFM)