Opened 6 years ago

Closed 6 years ago

#11124 closed Bug (fixed)

Invalid path in elementspath for div-based editor

Reported by: Marek Lewandowski Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.3
Component: General Version: 4.3
Keywords: Cc:

Description (last modified by Marek Lewandowski)

In current major

We have a regress after git:0c426c592ce.

  1. open div-based sample
  2. click on very first headline inside editor
  3. elementspath will contain extra items from outside of editable div (extra body form div div div)

Expected result:
Elementspath should show: div p

Current result:
Current elementspath displays: body form div div div div p

Change History (9)

comment:1 Changed 6 years ago by Marek Lewandowski

Description: modified (diff)

comment:2 Changed 6 years ago by Olek Nowodziński

Status: newconfirmed

comment:3 Changed 6 years ago by Marek Lewandowski

Description: modified (diff)
Owner: set to Marek Lewandowski
Status: confirmedassigned

comment:4 Changed 6 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.3

comment:5 Changed 6 years ago by Marek Lewandowski

Status: assignedreview

Pushed with t/11124 to dev and tests.

comment:6 Changed 6 years ago by Olek Nowodziński

Owner: changed from Marek Lewandowski to Olek Nowodziński
Status: reviewassigned

comment:7 Changed 6 years ago by Marek Lewandowski

Description: modified (diff)

I was wrong about commit which caused the failure, fixed now to git:0c426c592ce

comment:8 Changed 6 years ago by Olek Nowodziński

Status: assignedreview

I simplified the solution in t/11124b by using editor.elementPath().

Added tests to t/11124b that clone those of dt/plugins/elementspath/elementspath.html but with divarea plugin loaded (nasty but fast).

comment:9 Changed 6 years ago by Piotrek Koszuliński

Resolution: fixed
Status: reviewclosed

Fixed on major with git:94c0a56 on dev and 07a45db on tests.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy