Opened 9 years ago
Closed 9 years ago
#11124 closed Bug (fixed)
Invalid path in elementspath for div-based editor
Reported by: | Marek Lewandowski | Owned by: | Olek Nowodziński |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.3 |
Component: | General | Version: | 4.3 |
Keywords: | Cc: |
Description (last modified by )
In current major
We have a regress after git:0c426c592ce.
- open div-based sample
- click on very first headline inside editor
- elementspath will contain extra items from outside of editable div (extra body form div div div)
Expected result:
Elementspath should show: div p
Current result:
Current elementspath displays: body form div div div div p
Change History (9)
comment:1 Changed 9 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 9 years ago by
Status: | new → confirmed |
---|
comment:3 Changed 9 years ago by
Description: | modified (diff) |
---|---|
Owner: | set to Marek Lewandowski |
Status: | confirmed → assigned |
comment:4 Changed 9 years ago by
Milestone: | → CKEditor 4.3 |
---|
comment:5 Changed 9 years ago by
Status: | assigned → review |
---|
comment:6 Changed 9 years ago by
Owner: | changed from Marek Lewandowski to Olek Nowodziński |
---|---|
Status: | review → assigned |
comment:7 Changed 9 years ago by
Description: | modified (diff) |
---|
I was wrong about commit which caused the failure, fixed now to git:0c426c592ce
comment:8 Changed 9 years ago by
Status: | assigned → review |
---|
I simplified the solution in t/11124b by using editor.elementPath()
.
Added tests to t/11124b that clone those of dt/plugins/elementspath/elementspath.html
but with divarea
plugin loaded (nasty but fast).
comment:9 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
Fixed on major with git:94c0a56 on dev and 07a45db on tests.
Pushed with t/11124 to dev and tests.