AVT: When a menu is open and focus is on a menu item in that open menu, pressing Up or Down Arrow keys cycle focus through the items in that menu

[Satya Minnekanti]

To reproduce the defect:

1. Open any CK Sample, keep cursor in editor body.

2. Press Alt + F10 to navigate in to toolbar.

3. Navigate to Spell Check As You Type button menu.

4. Press Enter to open the menu.

5. Keep Pressing Down Arrow key until you reach Check Spelling Option

6. Press Down arrow key one more time

Expected Result: Pressing Down Arrow key will cycle through the menu & focus moves to first option in the menu(which is Enable SCAYT)

Actual Result: Nothing happens & focus stays on last option in the menu. This is a violation of Accessibility Checkpoint 2.1a & 4.1b

Same issue happens when Navigating options in main Context Menu & sub-menus

Look at the following link for wai-aria authoring practices for button menu & keyboard interactions for menu ​http://www.w3.org/TR/wai-aria-practices/#menu

[Jakub Ś]

Yes you are right aria says that down/up arrow should cycle through menu. It has never worked that way from the very beginning but I'm setting start version as 4.0 since it is going to be in 4.x.

[Marek Lewandowski]

I've created two solutions:

​t/11125 - does the job but has code duplication
​t/11125b - reuses shared code, i would suggest pick that solution

I didn't create TC for that, as it would require calling very specific ui calls / many manual event simulations.

[Frederico Caldeira Knabben]

Sent a simpler solution to t/11125c.

[Olek Nowodziński]

Failing case:

1. Move focus to "Styles" combo.
2. Down arrow (compo opens).
3. Down arrow (first item is selected).
4. Up arrow.

Expected result: Focus moved to the last item of the combo.

Actual result: Nothing happens, the first item remains focused.

Notes:

• Skip 3. and the thing works as expected.
• It works for other combos without any limitations so the failing case is styles-specific.

---

Implementation concerns:

arguments.callee ​is evil and ​no longer supported in ES5. We should really avoid it. Alternatively:

• Named function expression:

  onKeyDown: function onKeyDown( keystroke, noCycle ) {
      ...
      return onKeyDown.call( this, keystroke, 1 );
      ...
  }
  

• Or even simpler, with this context since the code is a part of the prototype:

  return this.onKeyDown( keystroke, 1 );
  

[Olek Nowodziński]

Pushed two commits to the branch:

• Got rid of arguments.callee.
• Fixed failing case.

[Frederico Caldeira Knabben]

Pushed still another small correction to it.

[Frederico Caldeira Knabben]

Fixed with ​git:6378c87.