Opened 10 years ago

Last modified 10 years ago

#11126 closed Bug

Various issues when undoing when at the bottom of snapshots stack — at Version 7

Reported by: Olek Nowodziński Owned by:
Priority: Normal Milestone: CKEditor 4.3.2
Component: Core : Undo & Redo Version: 4.0
Keywords: Cc:

Description (last modified by Olek Nowodziński)

Surprisingly, for some reason, when multiple inline editor are in use (/samples/inlineall.html), they share (actually: abuse) one another's undo stack. It happens when CTRL+Z is pressed and there are no snapshots left on the current stack.

It doesn't look like a feature, really, and since the issue can be reproduced since 4.0 in different browsers, it's time we fixed it.

See attached video (recorded in FF) to know more.


Another TC. On IE open the inline all sample, focus one of the editors with more complex contents, type something and press CTRL+Z multiple times. Textfified version of the initial contents will be loaded.


Another TC in FF:

  1. http://ckeditor4.t/ckeditor/samples/replacebyclass.html
  2. Put the caret
    Apollo 11^
    
  3. Type "moo"
  4. C-z
    ^Apollo 11
    
  5. C-z
    ^
    Apollo 11
    

Expected

^Apollo 11

but another, native undo snapshot reverts the selection to the position initially set by the browser.

The reason

It seems that editor does not prevent the native undo if it reached the bottom of snapshots stack. It allows browser to do stuff and weird things happen.

Change History (8)

Changed 10 years ago by Olek Nowodziński

comment:1 Changed 10 years ago by Piotrek Koszuliński

cc

comment:2 Changed 10 years ago by Piotrek Koszuliński

Status: newconfirmed

comment:3 Changed 10 years ago by Piotrek Koszuliński

Description: modified (diff)
Summary: Shared undo stack between editorsVarious issues when undoing when at the bottom of snapshots stack

comment:4 Changed 10 years ago by Piotrek Koszuliński

Description: modified (diff)

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 4.3.1

comment:6 Changed 10 years ago by Olek Nowodziński

Description: modified (diff)
Milestone: CKEditor 4.3.2

comment:7 Changed 10 years ago by Olek Nowodziński

Description: modified (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy