Opened 11 years ago
Closed 11 years ago
#11140 closed Bug (fixed)
[IE11] Dragging anchors does not work
Reported by: | Piotrek Koszuliński | Owned by: | Piotr Jasiun |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.3.2 |
Component: | General | Version: | |
Keywords: | IE11 | Cc: |
Description
- Open inlineall sample.
- Drag an anchor.
- It disappears after drop.
Change History (15)
comment:1 Changed 11 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 11 years ago by
Milestone: | CKEditor 4.3.1 → CKEditor 4.3.2 |
---|
comment:3 Changed 11 years ago by
Owner: | set to Piotr Jasiun |
---|---|
Status: | confirmed → assigned |
comment:4 Changed 11 years ago by
Status: | assigned → review |
---|
comment:8 Changed 11 years ago by
Replying to Reinmar:
I cannot reproduce this issue on master any more :|.
Thank you, IE11, for resetting your compatibility view options. For some reason IE11 started loading pages in IE7 mode. Issue is still reproducible after I set correct mode.
comment:9 follow-up: 10 Changed 11 years ago by
Status: | review → review_failed |
---|
Failed for two reasons.
- There are padding and margin styles added without any explanation.
- But most importantly - I think that we should simplify empty anchors using fake objects (we do this already on Webkit and Blink) - I created a ticket #11377 and pushed there a prototype of a patch. It works better than t/11140 because it doesn't hardcode anchor's height. More work is needed though, so we need to make a decision whether we choose t/11140 for now and work on #11377 in CKEditor 4.4, or whether we can work on it for 4.3.2.
comment:10 Changed 11 years ago by
comment:11 Changed 11 years ago by
Ok. I set 4.4 for #11377.
Regarding t/11140 - besides unjustified changes mentioned in comment:9 I also noticed that for other than unsupported Opera<12 we use vertical-align:text-bottom
instead of middle
. So perhaps the same value will be more adequate for style used for empty anchors. But first we need to have a TC for it.
comment:12 Changed 11 years ago by
Status: | review_failed → review |
---|
Other browsers has a combination of vertical-align:text-bottom;
and height: 1.15em;
what puts anchor in the middle. If we add only vertical-align:text-bottom;
then anchor will looks different and bad (BTW: I realized that vertical-align:text-bottom;
on IE11 is vertical-align:bottom;
on Chrome and vice versa). Also without vertical-align
we get different results on different IEs.
So my suggestion is to use vertical-align:text-bottom;
and height: 1.15em;
on IE as it works on FF and Chrome. I checked all versions of IE from 8 to 11 with this two rules anchors on all of them looks like on Chrome and FF.
I also removed padding
and margin
rules and putted ticked again on review.
comment:14 Changed 11 years ago by
Status: | review → review_failed |
---|
We should not change now the behaviour on other browsers, because we are going to rewrite all that very soon (#11377). Also, branch contained a patch with two issues - doubled height rule and unnecessary space in CSS.
comment:15 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | review_failed → closed |
I decided to not waste more time and I chose the simplest solution. Issues was fixed on master with git:32485fa.
Changes in t/11140.