Opened 6 years ago

Closed 6 years ago

#11204 closed Bug (fixed)

Merge image2 styles into global contents.css

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.3.1
Component: Documentation & Samples Version: 4.3
Keywords: Cc:

Description

Samples available in CKEditor package generated with image2 and without image plugin don't look well if someone adds caption to an image.

Change History (4)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newassigned

comment:2 Changed 6 years ago by Piotrek Koszuliński

Status: assignedreview

Pushed t/11204 with a patch.

However, I think that maybe we should remove the '.caption' class from these selectors, so those styles are really generic.

comment:3 in reply to:  2 Changed 6 years ago by Olek Nowodziński

Status: reviewreview_passed

Replying to Reinmar:

Pushed t/11204 with a patch.

However, I think that maybe we should remove the '.caption' class from these selectors, so those styles are really generic.

I'm cool with it.

I rebased the branch on latest master and pushed two additional commits.

comment:4 Changed 6 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Fixed on master with git:0fab04e.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy