Opened 4 years ago

Last modified 2 years ago

#11227 confirmed Bug

dialog.validate.functions bugs

Reported by: Michael Johnson Owned by:
Priority: Normal Milestone:
Component: UI : Dialogs Version: 4.0
Keywords: HasPatch Cc:

Description (last modified by Jakub Ś)

The definition of the function returned from dialog.validate.functions suffers from two bugs.

  1. When obtaining the "value" from the arguments, the inner function should be referencing its own arguments, not those of the outer function.
  2. When calling functions, it should be using "call" and passing "this" so that other validation functions passed as arguments will have the item as "this" as they expect.

Attachments (1)

11227.patch (905 bytes) - added by Michael Johnson 4 years ago.
Patch to plugins.dialog.plugin.js

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by Michael Johnson

Attachment: 11227.patch added

Patch to plugins.dialog.plugin.js

comment:1 Changed 4 years ago by Michael Johnson

Component: GeneralUI : Dialogs
Version: 3.6.6 (SVN - trunk)

comment:2 Changed 2 years ago by Jakub Ś

Description: modified (diff)

comment:3 Changed 2 years ago by Jakub Ś

Status: newconfirmed
Version: 3.6.64.0

Same code is used in CKEditor 4.x.

  1. Perhaps it would be better to check both, arguments of inner and then outer function?
  2. Looks like it would give better flexibility to validate functions.

@dnetmj, could I as you to provide this fix as a pull request for CKEditor 4.x? You could provide this fix as a pull request for CKEditor 4.x? You could submit it to ckeditor-dev

If you decide to do so, please don't forget to describe exactly what or which bug this pull request fixes. Because tests are required, please also see ​http://docs.ckeditor.com/#!/guide/dev_contributing_code.

Last edited 2 years ago by Jakub Ś (previous) (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy