Opened 11 years ago
Closed 11 years ago
#11291 closed Task (fixed)
Update code style after recent changes to the code style guide
| Reported by: | Piotr Jasiun | Owned by: | Piotr Jasiun |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3.2 |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description (last modified by )
Global code style fix after following changes:
- Removed exception that there should be no spaces inside () in case of IIFE.
- Removed exception that dictionaries should be formatted in a short way without spaces.
Also, we'll fix all code style issues introduced by the automate reformatter which we used before CKEditor 4.0 and by us after 4.0.
Change History (5)
comment:1 Changed 11 years ago by
| Description: | modified (diff) |
|---|---|
| Status: | new → confirmed |
| Summary: | Code style in dev → Update code style after recent changes to the code style guide |
comment:2 Changed 11 years ago by
| Owner: | set to Piotr Jasiun |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 11 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 11 years ago by
| Status: | review → review_passed |
|---|
I reviewed t/11291 line by line and I also built CKEditor on master and t/11291 - builds were identical.
comment:5 Changed 11 years ago by
| Milestone: | → CKEditor 4.3.2 |
|---|---|
| Resolution: | → fixed |
| Status: | review_passed → closed |
Masterized: git:796ce70.
Note: See
TracTickets for help on using
tickets.
I applied script on all js files in dev project. Changes in t/11291.
There are plenty additional rules we could add to make it better but this is good enough. Script still does not support html file but not it is very stable and do not touch parts it should not touch (never).