Opened 6 years ago

Closed 6 years ago

#11291 closed Task (fixed)

Update code style after recent changes to the code style guide

Reported by: Piotr Jasiun Owned by: Piotr Jasiun
Priority: Normal Milestone: CKEditor 4.3.2
Component: General Version:
Keywords: Cc:

Description (last modified by Piotrek Koszuliński)

Global code style fix after following changes:

  1. Removed exception that there should be no spaces inside () in case of IIFE.
  2. Removed exception that dictionaries should be formatted in a short way without spaces.

Also, we'll fix all code style issues introduced by the automate reformatter which we used before CKEditor 4.0 and by us after 4.0.

Change History (5)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Description: modified (diff)
Status: newconfirmed
Summary: Code style in devUpdate code style after recent changes to the code style guide

comment:2 Changed 6 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: confirmedassigned

comment:3 Changed 6 years ago by Piotr Jasiun

Status: assignedreview

I applied script on all js files in dev project. Changes in t/11291.

There are plenty additional rules we could add to make it better but this is good enough. Script still does not support html file but not it is very stable and do not touch parts it should not touch (never).

comment:4 Changed 6 years ago by Piotrek Koszuliński

Status: reviewreview_passed

I reviewed t/11291 line by line and I also built CKEditor on master and t/11291 - builds were identical.

Last edited 6 years ago by Piotrek Koszuliński (previous) (diff)

comment:5 Changed 6 years ago by Piotr Jasiun

Milestone: CKEditor 4.3.2
Resolution: fixed
Status: review_passedclosed

Masterized: git:796ce70.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy