Opened 5 years ago

Closed 5 years ago

#11290 closed Bug (fixed)

[PR#66] Redundant code in sourcedialog plugin

Reported by: Marek Lewandowski Owned by: Marek Lewandowski
Priority: Normal Milestone: CKEditor 4.3.2
Component: General Version:
Keywords: Cc:

Description (last modified by Piotrek Koszuliński)

Until master

As github user stevewithington points out in pull request #66:

We have code duplication in plugins/sourcedialog/dialogs/sourcedialog.js which can be fixed very easily.

Change History (6)

comment:1 Changed 5 years ago by Piotrek Koszuliński

Description: modified (diff)
Status: newconfirmed
Summary: redunant code in sourcedialog plugin - pull request #66Redunant code in sourcedialog plugin - pull request #66

comment:2 Changed 5 years ago by Marek Lewandowski

Owner: set to Marek Lewandowski
Status: confirmedreview

Pushed to t/11290

comment:3 Changed 5 years ago by Marek Lewandowski

Summary: Redunant code in sourcedialog plugin - pull request #66[PR#66] Redunant code in sourcedialog plugin

Changed ticket title to meet our standards.

comment:4 Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:5 Changed 5 years ago by Marek Lewandowski

Summary: [PR#66] Redunant code in sourcedialog plugin[PR#66] Redundant code in sourcedialog plugin

fixed typo

comment:6 Changed 5 years ago by Marek Lewandowski

Resolution: fixed
Status: review_passedclosed

fixed with git:df273395c

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy