Opened 6 years ago

Closed 6 years ago

#11309 closed New Feature (fixed)

Xmas card plugin.

Reported by: Piotr Jasiun Owned by: Piotr Jasiun
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

Create Xmas card plugin.

Change History (8)

comment:1 Changed 6 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: newreview

May someone make a review before publishing this plugin? Changes in t/11309.

comment:2 Changed 6 years ago by Piotrek Koszuliński

JSLint issues.

Last edited 6 years ago by Piotrek Koszuliński (previous) (diff)

comment:3 Changed 6 years ago by Piotrek Koszuliński

Status: reviewreview_failed

comment:4 Changed 6 years ago by Piotr Jasiun

Status: review_failedreview

JSLint issues fixed.

comment:5 Changed 6 years ago by Olek Nowodziński

Status: reviewreview_failed

I pushed several commits to dev branch, fixing minor things here and there.

Additionally:

  • Why not CKEDITOR.template for coverHtml, style and cardHtml? We don't need to re-define lots of static strings every time the card is displayed.
  • I significantly reduced the size of the fonts with http://www.fontsquirrel.com/tools/webfont-generator, using "Basic Subsetting" only (other tweaks off). If we don't want to support additional languages (the list is pretty long), we can use this trick. Otherwise, just ignore it ;)
  • Unused file GreatVibes-Regular.otf
  • A11y: there's no way to close the dialog. ESC key maybe?
  • Is "SIL OPEN FONT LICENSE Version 1.1 - 1 February 2007" compatible with our licenses?
  • [At least in latest Chrome]
    1. Open the card.
    2. Click the link at the bottom.
    3. The new browser tab is opened.
    4. Close the tab, so you go back to the page with CKEditor.
    5. The card disappears when returning to the page (some focusmanager issue?).

comment:6 in reply to:  5 Changed 6 years ago by Piotr Jasiun

Status: review_failedreview

Replying to a.nowodzinski:

I pushed several commits to dev branch, fixing minor things here and there.

Additionally:

  • Why not CKEDITOR.template for coverHtml, style and cardHtml? We don't need to re-define lots of static strings every time the card is displayed.

I do not belive that cart will be displayed multiple times.

We want to support multiple languages.

  • Unused file GreatVibes-Regular.otf

This is original font file and I'm not sure if I can delete it because of licence.

  • A11y: there's no way to close the dialog. ESC key maybe?

Fixed.

  • Is "SIL OPEN FONT LICENSE Version 1.1 - 1 February 2007" compatible with our licenses?

Seba checked it.

  • [At least in latest Chrome]
    1. Open the card.
    2. Click the link at the bottom.
    3. The new browser tab is opened.
    4. Close the tab, so you go back to the page with CKEditor.
    5. The card disappears when returning to the page (some focusmanager issue?).

Fixed.

Additionally I changed slightly CSS and now card looks more like card.

Changes in t/11309.

comment:7 Changed 6 years ago by Olek Nowodziński

Status: reviewreview_passed

Last but not least:

  • Use CKEDITOR.tools.cssVendorPrefix for vendor prefixes.
  • Extra white space in L120 :D
  • -5deg instead of -10deg and it will be perfect ;)

comment:8 Changed 6 years ago by Piotr Jasiun

Resolution: fixed
Status: review_passedclosed

Putted in sepatare github repo: https://github.com/ckeditor/ckeditor-plugin-xmas

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy