Special characters are encoded twice in nested editables

[vAx]

Using åäö and alike in the caption gets converted to ä but so does the & part so if you take a look at the source it looks lite this: ä

to reproduce this just go to ​http://ckeditor.com/demo#widgets and the image tool heading, change the "Apollo CMS-LM spacecraft" caption to include ä for example then take a look at the source.

TC

1. Open image2 sample.
2. Paste "åäö" into the caption.
3. Switch between modes twice.
4. In wysiwyg you get "åäö".

[Piotrek Koszuliński]

I believe that I wrote tests against doubled encoding. So this is not a widget's only issue - most likely it's a conflict with the entities plugin.

[Olek Nowodziński]

Pushed solution to ​t/11372 (+test branch).

It turned out to be much more complex than expected:

1. The problem was that, because of ​applyToAll used in entities plugin to solve #11250, dataFilter rule was executed twice: for all editor contents and for nested editable. Double execution implied double replacement:

   return text.replace( baseEntitiesRegex, getChar ).replace( entitiesRegex, getEntity );
   

2. To avoid re-writing dataFilter logic from scratch (it's a matter of time though), I introduced excludeNestedEditable option so that filtering and replacement are done only once, for nested editable only, while filtering of editor contents excludes nested editables.

3. Surprisingly, I realized that despite of excludeNestedEditable the problem still occured. It was because filtering defined in Entities plugin was executed in between ​two toDataFormat listeners of different priorities (8 and 13) in Widget plugin. Those listeners, designed to downcast but to preserve data-cke-* attributes for the "target filtering", precisely the first one, downcasted nested editables, which made excludeNestedEditable unaware of the "history" of parsed element and incapable of protecting its contents.

I postponed downcasting of nested editables and put it into the second toDataFormat listener, which seems to be harmless (at least tests pass).

[Piotrek Koszuliński]

A rule:

addRules( {...}, { excludeNestedEditable: true } )

will be applied to all elements in:

<div><p contenteditable="true">x</p></div>

That's because isRuleApplicable makes assumption that context.nestedEditable may be true only if context.nonEditable is true. They should be independent to avoid weird situations like the one above.

[Piotrek Koszuliński]

DUP closed #11391.

[Piotrek Koszuliński]

Pushed t/11372 branches. They contain additional tests and fix for issue mentioned in comment:6.

[Olek Nowodziński]

​git:d138ae0 landed in master (18501ac tests).