Opened 5 years ago

Closed 5 years ago

#11379 closed Bug (fixed)

Default line-height should be unitless

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.3.2
Component: General Version:
Keywords: Cc:

Description (last modified by Piotrek Koszuliński)

Currently it's set to 1.6em. It causes that text overlaps in following content:

<p><span style="font-size:72px">Foo</span></p>

<p><span style="font-size:72px">Foo</span></p>

<ul>
	<li><span style="font-size:72px">Bar</span></li>
	<li><span style="font-size:72px">Bom</span></li>
</ul>

Fixes

Attachments (3)

Selection_156.png (22.2 KB) - added by Piotrek Koszuliński 5 years ago.
Selection_157.png (25.1 KB) - added by Piotrek Koszuliński 5 years ago.
Selection_158.png (25.4 KB) - added by Piotrek Koszuliński 5 years ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by Piotrek Koszuliński

Attachment: Selection_156.png added

comment:1 Changed 5 years ago by Piotrek Koszuliński

Description: modified (diff)

comment:2 Changed 5 years ago by Piotrek Koszuliński

Description: modified (diff)

Changed 5 years ago by Piotrek Koszuliński

Attachment: Selection_157.png added

Changed 5 years ago by Piotrek Koszuliński

Attachment: Selection_158.png added

comment:3 Changed 5 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.3.2
Owner: set to Piotrek Koszuliński
Status: newreview
Summary: Default line-height should be proportionalDefault line-height should be unitless

Pushed t/11379 with a solution.

No more text overlapping:

And the same behaviour as previous settings:

Read more here: https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#Prefer_unitless_numbers_for_line-height_values

comment:4 Changed 5 years ago by Piotrek Koszuliński

Description: modified (diff)

comment:5 Changed 5 years ago by Olek Nowodziński

Status: reviewreview_passed

The change looks good to me. Any imperfections in styling will be revealed while testing anyway.

comment:6 Changed 5 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Fixed on master with git:878898d.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy