Opened 6 years ago

Closed 6 years ago

#11416 closed Bug (fixed)

[OSX,Webkit,Blink,Inline] Unable to undo the first text cut in inline editor

Reported by: Olek Nowodziński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.3.2
Component: Core : Undo & Redo Version: 4.3.2
Keywords: Cc:

Description (last modified by Olek Nowodziński)

  1. In Chrome/Safari open samples/inlineall.html
  2. Select text.
  3. C-x
  4. C-z

Expected: Cut is undone.

Actual: Nothing happens, undo is TRISTATE_DISABLED.

  1. Select some other text (in the same editor).
  2. C-x
  3. C-z (the second cut is undone).
  4. C-z (surprisingly the first cut is also undone).

In my opinion this bug was always there, but it was hidden by browser's native undo, which we fixed in #11126, so it eventually emerged.

It appears to be OSX-related bug only. Works perfectly in Linux.

Change History (7)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.3.2

comment:2 Changed 6 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newassigned

comment:3 Changed 6 years ago by Olek Nowodziński

Description: modified (diff)
Summary: [Webkit,Blink, Inline] Unable to undo the first text cut in inline editor[OSX,Webkit,Blink,Inline] Unable to undo the first text cut in inline editor

comment:4 Changed 6 years ago by Piotrek Koszuliński

Owner: Olek Nowodziński deleted
Status: assignedconfirmed

Pushed t/11416. Maybe safe and may be enough. Although, in widgets we used 100ms as a result of constant problems with copying and cutting.

comment:5 Changed 6 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: confirmedreview

comment:6 Changed 6 years ago by Olek Nowodziński

I pushed another commit to the branch, increasing the timeout to 50. It turned out that although 10 is enough for Chrome@OSX, 20 is needed for Safari. Finally I decided to make it 50. Just in case ;)

comment:7 Changed 6 years ago by Olek Nowodziński

Resolution: fixed
Status: reviewclosed

git:632a7ef landed in master.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy