Opened 11 years ago
Closed 11 years ago
#11416 closed Bug (fixed)
[OSX,Webkit,Blink,Inline] Unable to undo the first text cut in inline editor
Reported by: | Olek Nowodziński | Owned by: | Piotrek Koszuliński |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.3.2 |
Component: | Core : Undo & Redo | Version: | 4.3.2 |
Keywords: | Cc: |
Description (last modified by )
- In Chrome/Safari open samples/inlineall.html
- Select text.
- C-x
- C-z
Expected: Cut is undone.
Actual: Nothing happens, undo is TRISTATE_DISABLED
.
- Select some other text (in the same editor).
- C-x
- C-z (the second cut is undone).
- C-z (surprisingly the first cut is also undone).
In my opinion this bug was always there, but it was hidden by browser's native undo, which we fixed in #11126, so it eventually emerged.
It appears to be OSX-related bug only. Works perfectly in Linux.
Change History (7)
comment:1 Changed 11 years ago by
Milestone: | → CKEditor 4.3.2 |
---|
comment:2 Changed 11 years ago by
Owner: | set to Olek Nowodziński |
---|---|
Status: | new → assigned |
comment:3 Changed 11 years ago by
Description: | modified (diff) |
---|---|
Summary: | [Webkit,Blink, Inline] Unable to undo the first text cut in inline editor → [OSX,Webkit,Blink,Inline] Unable to undo the first text cut in inline editor |
comment:4 Changed 11 years ago by
Owner: | Olek Nowodziński deleted |
---|---|
Status: | assigned → confirmed |
comment:5 Changed 11 years ago by
Owner: | set to Piotrek Koszuliński |
---|---|
Status: | confirmed → review |
comment:6 Changed 11 years ago by
I pushed another commit to the branch, increasing the timeout to 50. It turned out that although 10 is enough for Chrome@OSX, 20 is needed for Safari. Finally I decided to make it 50. Just in case ;)
comment:7 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
git:632a7ef landed in master.
Pushed t/11416. Maybe safe and may be enough. Although, in widgets we used 100ms as a result of constant problems with copying and cutting.