Opened 11 years ago
Closed 11 years ago
#11487 closed Bug (fixed)
Mousing-over an image when using the enhanced image plugin results in the dirty flag being set
Reported by: | evant | Owned by: | Marek Lewandowski |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.3.3 |
Component: | UI : Widgets | Version: | 4.3.2 |
Keywords: | Cc: |
Description
I have a site that utilises CKEditor 4.3.2 in an inline configuration. I use the checkDirty() function to check whether the editor contents have changed whenever a user tries to navigate to another page within the site, and prompt them to save if the contents have changed. This functionality worked perfectly until I replaced the original image plugin with the new widget-based enhanced image plugin.
As soon as I did this, every time I mouse-over an image, the dirty flag becomes set, even if the editor toolbar is not actually instantiated. Essentially, all you have to do to trigger this behaviour is mouse-over an image when using the enhanced image plugin, and the editor seems to think that the contents have changed. If I avoid mousing over images, the issue does not occur.
I can reproduce the problem using Firefox 26, Chrome 32.0.1700.76 and Internet Explorer 11.
In all other respects, the enhanced image plugin seems to function fine.
Attachments (1)
Change History (6)
Changed 11 years ago by
Attachment: | build-config.js added |
---|
comment:1 Changed 11 years ago by
Milestone: | → CKEditor 4.3.3 |
---|---|
Status: | new → confirmed |
Fix for this issue will have to look similarly to https://github.com/ckeditor/ckeditor-dev/blob/master/core/editable.js#L1041-L1049. We could also think about integrating checkDirty lock with snapshots locking.
comment:2 Changed 11 years ago by
Owner: | set to Marek Lewandowski |
---|---|
Status: | confirmed → assigned |
comment:3 Changed 11 years ago by
Status: | assigned → review |
---|
Pushed to t/11487 at dev and t/11487 at tests.
comment:4 Changed 11 years ago by
Status: | review → review_passed |
---|
Pushed one commit to branch:t/11487.
comment:5 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with git:c018e2daa1 (merged to master) at dev and 9903cdf3b3 (merged to master) at tests.
Build Config