Opened 6 years ago

Last modified 6 years ago

#11488 confirmed Bug

Dialog content empty when it is told it will have tabs

Reported by: eugene88 Owned by:
Priority: Normal Milestone:
Component: UI : Dialogs Version: 4.1
Keywords: Cc:

Description

In Simple Plugin (Part 1) guide, in Dialog Window Tabs part, after first code segment, there is a phrase, that tells reader, that result of changes in code segment can be seen immediately and that it will have two tabs in place.

Expected: As told Instead: There are no tabs, assuming because the tabs have no elements inside at that moment.

http://docs.ckeditor.com/#!/guide/plugin_sdk_sample_1

Change History (4)

comment:1 Changed 6 years ago by eugene88

Keywords: tabs dialog added

comment:2 Changed 6 years ago by Jakub Ś

Component: Documentation & SamplesUI : Dialogs
Keywords: tabs dialog removed
Status: newconfirmed
Version: 4.3.14.1

Problem can be reproduced from CKEditor 4.1.

comment:3 Changed 6 years ago by Piotrek Koszuliński

We need to think whether the change made in 4.1 was good, because it may be also considered as a bug. In this case docs are ok, but code is wrong.

comment:4 in reply to:  3 Changed 6 years ago by eugene88

Replying to Reinmar:

We need to think whether the change made in 4.1 was good, because it may be also considered as a bug. In this case docs are ok, but code is wrong.


From one point of view logic in documentation is correct. Developer should see the result of his work. In this case even if tabs are empty, they probably should be visible. The other point of view is that cluttering the view with unnecessary elements might tend to confuse others.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy