Opened 6 years ago

Last modified 6 years ago

#11743 confirmed Bug

Exception flood caused by calling nativeSelection.createRange()

Reported by: Danil Owned by:
Priority: Normal Milestone:
Component: Core : Selection Version:
Keywords: Cc:

Description

Steps to reproduce in Google Chrome, but should be relevant for any browser: Open browser builtin Developer Tools, set "pause on exception" option. You get a series of debugger pauses every time you try to focus on CKEditor.

This issue makes a debugging difficult. Additionally, this is a waist of processor ticks :) .

Change History (1)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Status: newconfirmed
Version: 4.3.5 (GitHub - master)

You're right. I never liked those tools.tryThese: https://github.com/ckeditor/ckeditor-dev/blob/master/core/selection.js#L1587

Additionally, that shows that on single selection change getSelectedElement is called multiple times - once for every "align" button. This is worth rethinking, because we can anticipate what data may be needed in command#refresh or editor#selectionChange and prepare all these data. It could either happen in "preloaded" selection instance or simply in the event data.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy