Opened 5 years ago

Last modified 5 years ago

#11767 confirmed Bug

Table Tools spanning not updated

Reported by: Eugen Owned by:
Priority: Normal Milestone:
Component: General Version: 3.0
Keywords: Cc:

Description

Testcase:

Use IE or FF to be able to easily visualize the issue, in the source its broken for all browsers thogh

  1. Go on http://ckeditor.com/demo
  2. Create a table with 4x4
  3. select Cell 1x1 and set row-spanning to 10
  4. You now have a broken spanning since it is not validated

A more common use-case for normal users would be

  1. Go on http://ckeditor.com/demo
  2. Create a table with 4x4
  3. 3. select Cell 1x1 and set row-spanning to 10
  4. Delete a row -> spanning is not set to 9, instead of getting recoundet and fixed

Basically there is no sense in not validating the data since this is an editor for a user, not developer. In a table with a lot of rows you can easily count wrong and end up having a broken table.

Solution:

a) caluculate max span for col/rowspan before entering the dialog and offer a select-widget rather then an input field b) validate on save

You could also reuse such a table validator: http://jsfiddle.net/UkV35/8/

Change History (1)

comment:1 Changed 5 years ago by Jakub Ś

Status: newconfirmed
Version: 4.3.43.0

Thanks for the validation code snippet. We will definitely need to introduce something like that for tables.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy