Opened 9 years ago
Closed 9 years ago
#11957 closed Bug (fixed)
[Image2] Alignment labels in the dialog are not translated
| Reported by: | Olek Nowodziński | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.4.2 |
| Component: | UI : Dialogs | Version: | 4.3 |
| Keywords: | Cc: |
Description
At the moment labels are hardcoded and just look silly if changed editor language to Polish or any other.
Change History (8)
comment:1 Changed 9 years ago by
| Summary: | [Image2] Image2 alignment labels are not translated → [Image2] Alignment labels in the dialog are not translated |
|---|
comment:2 Changed 9 years ago by
| Status: | new → confirmed |
|---|
comment:3 Changed 9 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | confirmed → assigned |
comment:4 Changed 9 years ago by
| Status: | assigned → review |
|---|
comment:5 follow-up: 6 Changed 9 years ago by
It works now, but not for end user. Until we add translations for a diffrent languages there will be no text next to align none checkbox in image2 dialog. alignNone key is added only for english language.
comment:6 Changed 9 years ago by
Replying to a.delura:
It works now, but not for end user. Until we add translations for a diffrent languages there will be no text next to
align nonecheckbox in image2 dialog.alignNonekey is added only for english language.
Your concern is only valid for dev code. Once built, missing translations are automatically filled with english strings, just like https://github.com/ckeditor/ckeditor-dev/blob/master/lang/tt.js#L65-L67 and this is a part of our translation workflow. If what you said was true, we would not be able to extend any existing langfile until all remaining languages are 100% coherent, which is absurd ;)
comment:8 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Fixed on master with git:026c14e.
Fix pushed to branch:t/11957.