[IE, Chrome, Opera] Dialog box doesn't open on two words links with background.

[Artur Delura]

1. Open editor with following content

   Hello <a href="http://en.wikipedia.org/wiki/Neil_Armstrong">Neil Arm</a> .
   

2. Select link Neil Arm.
3. Change selection background color.
4. Double click Arm word to open link dialog.

Actual result: Dialog won't open.

Please note: Double click on word Neil open dialog properly.

[Jakub Ś]

I confirm this issue for Blink and IE8+.

Problem can in fact be reproduced from CKEditor 3.0 but I'm setting 4.0 for it because we don't support CKE 3.x anymore.

[Tomasz Jakut]

It seems that clicking the link which has descendants sometimes report that descendant as a clicked element (especially if link is immediately followed by unlinked text), so I just propose to check not only the clicked element, but also its ancestors to find the clicked link. Pushed fix to ​branch:t/11956.

[Olek Nowodziński]

1. ​https://github.com/cksource/ckeditor-dev/commit/7e25e68a7338b1bc57fae4db0155986849b8d6aa#diff-d9e496f4ce47ad70bef0ba672713d3a1R293 isn't it exactly the same as CKEDITOR.dom.node.getAscendant? If so, please use the core method.

2. I'd rather avoid using selection for assertions unless it is necessary (selection is slow and quirky). And since doubleclick listeners in Link Plugin communicate using evt.data object, and as long as the only thing that really matters here is whether a link has been detected, it's easier to fetch evt.data.link and check if The Link has been found, before selection kicks in. So I'd rather see it this way:

   // #11956
   'test select link with descendants on double-click': function() {
   	var bot = this.editorBot,
   		editor = bot.editor;
   
   	editor.once( 'doubleclick', function( evt ) {
   		evt.cancel();
   
   		resume( function() {
   			assert.areSame( editor.document.findOne( 'a' ), evt.data.link, 'Link selected' );
   		} );
   	} );
   
   	bot.setData( '<p>a<a href="http://bar"><span style="background:#f00;">b</span></a>c</p>', function() {
   		editor.fire( 'doubleclick', {
   			element: editor.document.findOne( 'span' )
   		} );
   
   		wait();
   	} );
   }
   

3. Other than that, I'm cool with the solution :)

[Tomasz Jakut]

1. Yes, they're the same. I've changed code to use element.getAscendant.
2. Test's updated.

Pushed to ​branch:t/11956.

[Olek Nowodziński]

I pushed 2 minor commits to the branch. Also found an issue:

1. Open ​http://ckeditor.dev/samples/.
2. Double–click any text, which is not a link.
3. uncaught TypeError: Cannot read property 'isReadOnly' of null(anonymous function) @ plugin.js:99 is thrown.

[Tomasz Jakut]

I've fixed that issue by adding additional check if element is set, as element.getAscendant returns nothing if there is no link.

Pushed ​branch:t/11956.

[Marek Lewandowski]

Moving tickets to the next milestone.

[Marek Lewandowski]

Moving to the nice to have list.

[kkrzton]

Rebased on the current major, targeting 4.7.0.

[kkrzton]

LGTM!

Updated manual test version tag and added elementspath plugin (so it is more visible what was selected) - ​aaddd57.

[kkrzton]

Merged to major with ​c390920.