Opened 10 years ago

Closed 10 years ago

#1197 closed Bug (fixed)

<blockquote> is not supported by the style system

Reported by: Wiktor Walc Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.5 Beta
Component: Core : Styles Version: SVN (FCKeditor) - Retired
Keywords: Cc:

Description

I have defined style that use "blockquote" element:

<!-- Object Styles -->
	<Style name="Quote" element="blockquote">
		<Attribute name="class" value="uncited" />
	</Style>

in older revisions of FCKeditor 2.5 it was working correctly, now in the latest revision it doesn't work (FCKeditor simply ignores it).

Is it expected behaviour and blockquote can't be used here?

Change History (4)

comment:1 Changed 10 years ago by Wiktor Walc

Milestone: FCKeditor 2.5

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Component: GeneralCore : Styles
Summary: blockquote in fckstyles.xml is ignored<blockquote> is not supported by the style system

The real problem here is that <blockquote> is not a "pure" block element. Actually, by recommendation, <blockquote> should always hold other block elements. the same thing is valid for <div>, specially when EnterMode='p', which is the default and recommended setting for FCKeditor.

So, the correct way to apply a <blockquote> is by using a dedicated button for it in the toolbar. That button would take the selected blocks and move them inside a <blockquote> tag. We could also consider having an entry for it in the style combo, which would do the same job as the button.

A similar solution should be created for the <div> element, with a complication that in this case we can have nested <div>s, which should not happen with <blockquote>.

Other than that, we must review the "Increase Indent" button, which today sadly create <blockquote> tags. It should instead change select block styles by adding a margin that indents the text.

It would be nice to have some feedback in this feature, just to be sure that we are in the right path.

comment:3 Changed 10 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

comment:4 Changed 10 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [850].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy