Opened 5 years ago

Closed 5 years ago

#12022 closed Bug (fixed)

[Nested widgets] Outer widget's drag handler is not created if it has any nested widgets

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.4.2
Component: UI : Widgets Version: 4.3 Beta
Keywords: Cc:

Description

Part of: #10931.

  1. Open plugins/widget/dev/nestedwidgets.html
  2. See that simple boxes don't have drag handlers.

The reason is that we try to find existing drag handler by findOne( '.cke_widget_drag_handler_container' ), so since nested widgets are already initialised while we do this, we find their handlers.

Note that changing order will not solve the issue because when pasting all widgets have drag handlers, so we'll find them anyone. And not necessarily the one we get from findOne is the main widget's handler.

Change History (4)

comment:1 Changed 5 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newassigned

comment:2 Changed 5 years ago by Piotrek Koszuliński

Status: assignedreview

Pushed branch:t/12022 on dev and tests.

I found an issue with outline and drag handler on FF though. Unpositioned handlers of nested widgets extends outline to the left (they are hidden outside of the view port).

comment:3 Changed 5 years ago by Olek Nowodziński

Status: reviewreview_passed

comment:4 Changed 5 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.4.2
Resolution: fixed
Status: review_passedclosed

Fixed on master with git:d50ebea on dev and 16e2fbc on tests.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy