Opened 9 years ago
Closed 9 years ago
#12111 closed Bug (fixed)
Image attributes read incorrectly in specific selection context
Reported by: | Marek Lewandowski | Owned by: | Marek Lewandowski |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.4.4 |
Component: | General | Version: | 4.4.1 |
Keywords: | Cc: |
Description (last modified by )
Checked only on IE10, but this issue might be also present in other IE versions
- open any sample with CKEditor and image plugin (i.e. samples/replacebyclass.html)
- use following source
<p>Text with <a href="http://ckeditor.com">li<img alt="" src="assets/sample.jpg" style="height:60px; width:48px" />nk</a> and image .</p>
- go back to wysiwyg mode
- double click image to check its properties
Expected result:
Properties like image source link, height and width should be predefined in text inputs.
Current result:
Properties are missing.
additional info:
- Desired information are available in dialog after Right Click / Image Properties.
- Seems to work OK in 4.4.0
Change History (14)
comment:1 Changed 9 years ago by
Summary: | [IE] Image attribute not readed correctly → [IE10] Image attribute not readed correctly |
---|
comment:2 Changed 9 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 9 years ago by
comment:4 Changed 9 years ago by
I reproduced it in Chrome and FF. It seems that the reason why it happens is that the link gets selected on double click but it's Image dialog which is opened.
comment:5 Changed 9 years ago by
Summary: | [IE10] Image attribute not readed correctly → Image attributes read incorrectly in specific selection context |
---|
comment:6 Changed 9 years ago by
Status: | new → confirmed |
---|
comment:7 Changed 9 years ago by
Description: | modified (diff) |
---|
comment:8 Changed 9 years ago by
Description: | modified (diff) |
---|
comment:10 Changed 9 years ago by
Milestone: | → CKEditor 4.4.3 |
---|
comment:11 Changed 9 years ago by
Milestone: | CKEditor 4.4.3 → CKEditor 4.4.4 |
---|
The 4.4.3 milestone was shortened, so the remaining tickets must be postponed.
comment:12 Changed 9 years ago by
Owner: | set to Marek Lewandowski |
---|---|
Status: | confirmed → assigned |
comment:13 Changed 9 years ago by
Status: | assigned → review |
---|
I had no good idea for the test placement, since it's an integration test for image + link plugin, and it tests very particular dependency. At the end I've put it to ticket tests.
Pushed to t/12111 at dev.
comment:14 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
Good job. Though, I had to use the %BASE_PATH% placeholder to generate src for image which will not give 404s and fix args order in one assert.
Fixed on master with git:8f4baa9.
Same goes for other kind of stuff like inputs etc.