Opened 10 years ago
Closed 10 years ago
#12110 closed Bug (fixed)
[PR#104] Editor crash after deleting a table.
Reported by: | Piotr Jasiun | Owned by: | Marek Lewandowski |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.4.3 |
Component: | General | Version: | 4.0 Beta |
Keywords: | Cc: | mike@… |
Description (last modified by )
Scenario:
- Have an inline initialized editor
- In that editor add a table and ensure that it is the sole element in the editable container (nothing before and nothing after)
- Use the contextual menu to delete the table
- The editor is no longer working :(
Note: This can be reproduced also on the demo site: http://ckeditor.com/demo#inline
The fix: Just added a check to not remove the parent element of the table if that parent is the container.
PR: https://github.com/ckeditor/ckeditor-dev/pull/104
Related ticket: #12122
Change History (7)
comment:1 Changed 10 years ago by
Status: | new → confirmed |
---|---|
Version: | → 4.0 Beta |
comment:3 Changed 10 years ago by
Cc: | mike@… added |
---|
comment:4 Changed 10 years ago by
Owner: | set to Marek Lewandowski |
---|---|
Status: | confirmed → assigned |
comment:5 Changed 10 years ago by
Status: | assigned → review |
---|
Branch rebased and pushed tests to t/12110 at dev.
I've also removed parent.is( 'body' )
part in git:f3468044ab - as it seems to be redundant to me when checking editable.equals( parent ).
From my testing it does not break removing table directly in fullpage mode - as fullpage <body/>
elmeent is still editable.
comment:6 Changed 10 years ago by
Description: | modified (diff) |
---|---|
Milestone: | → CKEditor 4.4.3 |
comment:7 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
Merged to master with git:89f4a31. Additionally, I needed to improve tools.html.compareInnerHtml - https://github.com/benderjs/benderjs-ckeditor/commit/08be96bcec82ab2779f226319d99fe8f025e1666
Warning for the future: verify that tests for code you're changing really work (and exist first of all). In this case test for removing table's wrapper existed but was buggy and was always green. That was masking a bug in code touched by this patch. This bug was introduced in this patch too. I stumbled upon this when trying to make that existing test fail, by commenting out the condition from dev code.
Problem can be reproduced from CKEditor 4.0 beta.
Reminded me #9315 but they are rather not related.