Remove format not working on widgets

[Tsvetelin Novkirishki]

Descriptive summary: When there are styles applied to a widget, Remove format does nothing.

Steps to reproduce:

1. Insert some widget
2. Bold it
3. Click on Remove format button and nothing happens

Browser and OS: Chrome and Firefox under both Windows and Linux

[Piotrek Koszuliński]

Confirmed. Remove format seems to lose widget selection.

[Marek Lewandowski]

Pushed to ​t/12135 at dev.

I think it would be pretty good to add also editor seleciton assertion after first assertion in test remove format outside the contenteditable=false:

assert.areEqual( '<p>[<span contenteditable="false">foo</span>]</p>', bender.tools.selection.getWithHtml( bot.editor ), 'editor seleciton' );

But <div data-cke-hidden-sel="1" data-cke-temp="1" style="position:fixed;top:0;left:-1000px">&nbsp;</div> is being added, any idea how to assert content gracefully in this case?

[Piotrek Koszuliński]

Hm... We can add this case to tools.html.compareInnerHtml, so it strips elements with data-cke-temp attributes. I've got to work on this function anyway, so I'll do that before reviewing. Leave this to me.

[Piotrek Koszuliński]

The 4.4.3 milestone was shortened, so the remaining tickets must be postponed.

[Piotrek Koszuliński]

In ​https://github.com/benderjs/benderjs-ckeditor/issues/7 and ​https://github.com/benderjs/benderjs-ckeditor/issues/8 I improved tools, so I'm able to resolve problem mentioned in comment:4 finally.

[Piotrek Koszuliński]

1. Please split tests into multiple cases (functions).
2. Split that one commit into a code style fixes and bug fix, because it's hard to understand what really is the fix and why it works.

[Marek Lewandowski]

Changed branch history.

Pushed to ​t/12135 at dev.

[Piotrek Koszuliński]

Corrected:

• Nested tags in tests (strong>strong)
• Selections finishing in non-editable locations - we do not allow them.
• The getNext's callback name.

Merged to master on ​git:8cabc81.