Opened 4 years ago

Closed 3 years ago

#12189 closed Bug (fixed)

Link plugin dialog does not display subject of email links if subject parameter is not lowercase

Reported by: Henning Owned by: Tomasz Jakut
Priority: Normal Milestone: CKEditor 4.5.5
Component: General Version: 3.0
Keywords: Cc:

Description

In CKEditor 4.3.5, add the following text in source mode:

<a href="mailto:huhu@momo.com?Subject=huhu%20momo!">ckeditor email link</a>

Switch to wysiwyg mode, open the link plugin dialog on the link. The email subject is not displayed in the link dialog. Change "Subject" to "subject" in source mode. Then the dialog will display the email subject.

I guess that the regex'es used in the pluign's link.js are not case-insensitive, what they should be.

Change History (5)

comment:1 Changed 3 years ago by Jakub Ś

Status: newconfirmed
Type: TaskBug
Version: 4.3.53.0

In ckeditor/plugins/link/plugin.js I have found emailSubjectRegex = /subject=([^;?:@&=$,\/]*)/,.

I also haven't found anything saying that capital letters are not allowed in query string. Even on W3schools there are examples with Subject and subject:
http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_link_mailto2
http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_link_mailto

Couldn't we just add 'i' flag there?

Last edited 3 years ago by Jakub Ś (previous) (diff)

comment:2 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.5

comment:3 Changed 3 years ago by Tomasz Jakut

Owner: set to Tomasz Jakut
Status: confirmedassigned

comment:4 Changed 3 years ago by Tomasz Jakut

Status: assignedreview

The same problem was with message's body, so I fixed it also. Pushed changes to branch:t/12189.

comment:5 Changed 3 years ago by Marek Lewandowski

Resolution: fixed
Status: reviewclosed

Good catch! Merged to master with git:01babe2349.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy