Opened 11 years ago
Last modified 11 years ago
#12219 closed Bug
UndoManager.locked volates strict mode in undo plugin — at Initial Version
Reported by: | Marek Lewandowski | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.4.4 |
Component: | General | Version: | |
Keywords: | Cc: |
Description
While working on #11739 I found out that at least these two linex violates strict mode (Safari6):
The reason for that is that (at least sometimes) undoManager.locked becomes a number. And if you attempt to add new property directly to a Number object it will cause a strict violation.
Steps to repro:
- ensure that your plugins/undo/plugin.js has a use strict statement
- run plugins/undo/change test
Expected result:
Tests should pass.
Current result:
Tests test undo
and test redo
will fail.
additional info:
- I've pushed temp workaround for this issue to t/11739_safari_fix branch.