Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12219 closed Bug (fixed)

[Safari] UndoManager.locked volates strict mode in undo plugin

Reported by: Marek Lewandowski Owned by:
Priority: Normal Milestone: CKEditor 4.4.4
Component: General Version:
Keywords: Cc:

Description (last modified by Marek Lewandowski)

While working on #11739 I found out that at least these two line violates strict mode (Safari6):

The reason for that is that (at least sometimes) undoManager.locked becomes a number. And if you attempt to add new property directly to a Number object it will cause a strict violation.

Steps to repro:

  1. ensure that your plugins/undo/plugin.js has a use strict statement
  2. run plugins/undo/change test

Expected result:
Tests should pass.

Current result:
Tests test undo and test redo will fail.

additional info:

  1. I've pushed temp workaround for this issue to t/11739_safari_fix branch.

Change History (4)

comment:1 Changed 4 years ago by Marek Lewandowski

Summary: UndoManager.locked volates strict mode in undo plugin[Webkit] UndoManager.locked volates strict mode in undo plugin

comment:2 Changed 4 years ago by Marek Lewandowski

Description: modified (diff)

comment:3 Changed 4 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.4.4
Resolution: fixed
Status: newclosed

Fixed in #11739.

comment:4 Changed 4 years ago by Piotrek Koszuliński

Summary: [Webkit] UndoManager.locked volates strict mode in undo plugin[Safari] UndoManager.locked volates strict mode in undo plugin
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy