Pasting from a Word (type) document loses formatting

[Alin Purcaru]

Description:

When pasting from MS Word, Libre/Open Office documents some of the formatting is lost. Upon checking the HTML generated it can be observed that the style attribute has incorrectly separated definition (missing ';').

Steps to reproduce:

1. Use the attached test.odt as a sample (although the problem can be reproduced with other formats too).
2. Click on the Paste from Word button (you will observe that the formatting is kept at this point).
3. Click OK.
4. Part of the formatting (in this case the text color for the first paragraph) is lost.

System details:

Ubuntu 14.04, Chrome 35

CKEditor instance config:

CKEDITOR.inline( ... , {
    ...
    allowedContent: true,
    pasteFromWordRemoveFontStyles: false,
    pasteFromWordRemoveStyles: false
});

Note: I have already found the problem and fixed it and will create a pull request for ckeditor/ckeditor-dev on github. I'm posting this bug to have it as reference.

[Alin Purcaru]

Pull request with the fix: ​https://github.com/ckeditor/ckeditor-dev/pull/117

[Olek Nowodziński]

I reviewed this PR, which appears to be good. We should not concatenate strings while dealing with styles though. I improved the fix to avoid similar issues in the future.

​git:88898049 merged into master.

[Piotrek Koszuliński]

As for working with styles we've got a pretty good parser and writer in CKEDITOR.tools. But of course it's hard to start using them everywhere now.