Opened 17 years ago
Closed 17 years ago
#1227 closed Bug (fixed)
Stop caching panel type in FCK._ActiveColorPanelType
Reported by: | Matthias Miller | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | FCKeditor 2.5 Beta |
Component: | General | Version: | |
Keywords: | Cc: |
Description
Currently, when the color panel opens its popup, it caches the current color type (ForeColor vs. BackColor) in FCK._ActiveColorPanelType
. Although I don't know the history of this variable, it appears that the panel type can safely be retrieved from this.Type
.
This would allow other code (besides the popup) to change the selected text to a specific color.
Attachments (1)
Change History (2)
Changed 17 years ago by
Attachment: | fcktextcolorcommand.js.patch added |
---|
comment:1 Changed 17 years ago by
Milestone: | → FCKeditor 2.5 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
You're right, I don't see any reason to keep it.
Fixed with [828], thanks.