Opened 5 years ago

Closed 5 years ago

#12308 closed Bug (fixed)

Regression in iterator after #12178 - iterator leaks

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.4.4
Component: General Version: 4.4.4
Keywords: Cc:

Change History (3)

comment:1 Changed 5 years ago by Piotrek Koszuliński

Explanation:

  • We start with: <p>foo^<br></p><h1>bar</h1>.
  • We find that start of selection is at the end of <p>.
  • After range is shrank we try to fix it to avoid #12178, so we set its start at the end of <p>.
  • This makes a following range: `<p>foo]<br>[</p><h1>bar</h1>'.
  • It's obviously incorrect and iterator leaks from the paragraph.

comment:2 Changed 5 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newassigned

comment:3 Changed 5 years ago by Piotrek Koszuliński

Resolution: fixed
Status: assignedclosed

I wasn't able to implement iterator's test that would fail. There must be some special condition which occurs in the list test. So let it be the validator of the patch. Additionally, I implemented additional test in iterator just in case.

Fixed on master with git:fc8748b.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy