Test test_getDocumentPosition in core.dom.element.element in unstable

[Artur Delura]

​http://tests.ckeditor.dev:1030/tests/core/dom/element/element#test_getDocumentPosition

On IE11 I've something like this: Expected: 350 (number) Actual: 351 (number)

We should add some acceptance error range.

[Artur Delura]

Changes in ​branch:t/12309

[Artur Delura]

Improved tests - changes in the same branch.

[Piotrek Koszuliński]

1. The assertion function does not check type of expected value.
2. Instead of swapping min with max better throw an error because if min>max, then it means that the code using assertion is wrong. Swapping leads to a silent error.
3. You used the assertion function in the wrong way - you mixed expected value with a range in element/element.js

[Artur Delura]

Changes in the same ​branch:t/12309.

[Piotrek Koszuliński]

1. tests/utils/assert/isNumberInRange.js - wrong file name
2. ​https://github.com/cksource/ckeditor-dev/commit/c150c3ad8a54145299e8b5722ce50f0287a2f9f0#diff-29fe8c260592a68a6c2e2a5f2dea1f0fL10 - what's this? :P
3. ​https://github.com/cksource/ckeditor-dev/commit/c150c3ad8a54145299e8b5722ce50f0287a2f9f0#diff-43a3fceb3bf7ceb96aabbe46fd4a9101R93 - you can use assert.isNumber and you won't need to throw errors manually.

[Artur Delura]

Replying to Reinmar:

1. tests/utils/assert/isNumberInRange.js - wrong file name

Done.

2. ​https://github.com/cksource/ckeditor-dev/commit/c150c3ad8a54145299e8b5722ce50f0287a2f9f0#diff-29fe8c260592a68a6c2e2a5f2dea1f0fL10 - what's this? :P

Removed, to keep consistency with closest environment.

3. ​https://github.com/cksource/ckeditor-dev/commit/c150c3ad8a54145299e8b5722ce50f0287a2f9f0#diff-43a3fceb3bf7ceb96aabbe46fd4a9101R93 - you can use assert.isNumber and you won't need to throw errors manually.

Yeach, less code :)

Changes in the same ​branch:t/12309.

[Piotrek Koszuliński]

Merged to master with ​git:b60bb80.

I added one commit which improved tests and made min==max invalid (because in such case assert.areEqual/areSame should be used).