Opened 4 years ago

Closed 4 years ago

#12338 closed Bug (fixed)

CKEditor 4.4.4 has new, unoptimized images

Reported by: Wim Leers Owned by: Artur Delura
Priority: Normal Milestone: CKEditor 4.4.5
Component: General Version: 4.4.4
Keywords: Cc: wim.leers@…

Description (last modified by Wim Leers)

plugins/magicline/icon-rtl.png is 3KB, could be 112 bytes

plugins/magicline/hidpi/icon-rtl.png is 3 KB, could be 148 bytes

Change History (6)

comment:1 Changed 4 years ago by Wim Leers

Description: modified (diff)

comment:2 Changed 4 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.4.5
Status: newconfirmed

Actually we should optimise all images which are not icons (which are not taken into icons strip by builder). All this should be done by builder, but for various reasons it won't be possible now, so we need to do this manually. See more in https://github.com/ckeditor/ckeditor-dev/pull/112#issuecomment-50152717

comment:3 Changed 4 years ago by Wim Leers

Thanks for the explanation.

I added a suggestion at https://github.com/ckeditor/ckeditor-dev/pull/112#issuecomment-52899260 that might be helpful.

Last edited 4 years ago by Wim Leers (previous) (diff)

comment:4 Changed 4 years ago by Artur Delura

Owner: set to Artur Delura
Status: confirmedassigned

comment:5 Changed 4 years ago by Artur Delura

Status: assignedreview

I created grunt task in ckeditor-dev repository and called it optimizeimages. Changes are in branch:t/12338. This task use optipng library. Unfortunatelly I couldn't find other optimization tool which is provided as a grunt plugin.

comment:6 Changed 4 years ago by Piotrek Koszuliński

Resolution: fixed
Status: reviewclosed

Fixed on master with git:590deeb. I covered few more images with the task and renamed it to images.

Next time please remember about JSHint.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy