Opened 5 years ago

Last modified 5 years ago

#12453 confirmed Bug

CKEditor in IE11 doesn't handle large tables.

Reported by: Jakub Ś Owned by:
Priority: Normal Milestone:
Component: General Version: 4.3
Keywords: IE11 Support Cc: satya_minnekanti@…

Description

  1. Open replacebycode sample in IE11.
  2. Insert 300x300 table.

Result: page hangs after a while. The table is not inserted.

Problem can be reproduced only in IE11 from CKEditor 4.3

Change History (5)

comment:1 Changed 5 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 5 years ago by Frederico Caldeira Knabben

We're talking about 90,000 cells. If it would take 10 seconds average for the user to put something on each cell, it would take 250 hours to finish it. Sincerely, it doesn't look like a realistic use case.

The only think we could take in consideration is that the user may eventually set these values by mistake and then page hanging is not the best thing to have. We could eventually consider limiting the maximum size of the table.

comment:3 Changed 5 years ago by Piotrek Koszuliński

Yes, this is totally unrealistic case. And there's not much we can do, because my tests show that this is native methods and rendering what take so much time.

However, setting maximum table size to something like 50 columns and 100 rows makes sense. I remember people asking for this in some other ticket.

comment:4 Changed 5 years ago by Piotrek Koszuliński

BTW. I found that nativeSel.toString() method is extremely slow in this case. We call it when locking selection so it can be saved on editable blur. The thing is that... we wouldn't need to do that if we haven't got sel.getSelectedText() method which isn't needed by any of our plugins.

So some kind of workaround will be to remove this line https://github.com/ckeditor/ckeditor-dev/blob/3cf4f012aea6dbc52ff45b64e3e3f86be4a46a70/core/selection.js#L1647

Our plugins should still work and editor will become 2-3x more responsive when inserting and editing such huge tables.

comment:5 Changed 5 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy